AIESW-31422:Fix use of deprecated kernel apis.#9761
Open
svup-xilinx wants to merge 1 commit intoXilinx:masterfrom
Open
AIESW-31422:Fix use of deprecated kernel apis.#9761svup-xilinx wants to merge 1 commit intoXilinx:masterfrom
svup-xilinx wants to merge 1 commit intoXilinx:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Added compatibility shim for both kernel constructor overloads using modern hw_context API internally to eliminate C++ deprecation warnings while maintaining Python backward compatibility. - kernel(device, uuid, name) → uses hw_context with shared mode - kernel(device, uuid, name, mode) → uses hw_context with specified mode - Issues Python DeprecationWarning for migration guidance - Fixes the issue properly instead of suppressing warnings on Windows. Signed-off-by: Srikanth Vuppala <120363307+svup-xilinx@users.noreply.github.com>
svup-xilinx
force-pushed
the
AIESW-31422
branch
from
5a903e6 to
fe3c7a3
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
chvamshi-xilinx
approved these changes
Apr 30, 2026
stsoe
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
The deprecated constructors kernel (device, uuid, name) and kernel (device, uuid, name, mode) were being called directly from Python bindings, causing compilation failures
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
AIESW-31422
How problem was solved, alternative solutions (if any) and why they were rejected
Added compatibility shim for both kernel constructor overloads using modern hw_context API internally to eliminate C++ deprecation warnings while maintaining Python backward compatibility.
Risks (if any) associated the changes in the commit
Python.
What has been tested and how, request additional testing if necessary
Tested on windows with custom made test on Strix machine.
Documentation impact (if any)
None. Runtime warnings guide users to modern API.