xrt-smi code cleanup#9765
Open
aktondak wants to merge 1 commit intoXilinx:masterfrom
Open
Conversation
Signed-off-by: Akshay Tondak <aktondak@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR is a code re-organizationa and cleanup. No new functional logic has been implementation/changed. Following are the changes made :
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/AIESW-31768
How problem was solved, alternative solutions (if any) and why they were rejected)
Risks (if any) associated the changes in the commit
None. This code change is just a cleanup before further code changes are made to extend this functionality to global xrt-smi options required for https://jira.xilinx.com/browse/AIESW-29548
What has been tested and how, request additional testing if necessary
Tested on Linux. Works as expected.
Documentation impact (if any)
None