Skip to content

Replace deprecated APIs in core/common #9825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hyunjiki-amd wants to merge 9 commits into
base: master
Choose a base branch
from
+10 −9
Draft

Replace deprecated APIs in core/common #9825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
44e0e18
Replace banned APIs
hyunjiki-amd May 12, 2026
7b85909
Add secure cross-platform wrapper
hyunjiki-amd May 19, 2026
0aba05d
Modify str_wrapper.h to exclude Linux implementation
hyunjiki-amd May 19, 2026
42e6b17
Modify str_wrapper.h and add str_wrapper.cpp
hyunjiki-amd May 20, 2026
e4c9b1b
Add an example usage of xrt_core::str_wrapper
hyunjiki-amd May 20, 2026
c775736
Add str_wrapper.cpp to the build
hyunjiki-amd May 20, 2026
8b49f3b
Modify xrt_error.cpp and add rt_printf_impl.cpp as an example
hyunjiki-amd May 20, 2026
610fa6e
Remove the wrapper
hyunjiki-amd May 20, 2026
f25f0d6
Change xrt_xclbin.cpp
hyunjiki-amd May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/runtime_src/core/common/api/xrt_error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
#include <map>
#include <cstring>

#ifdef _WIN32
# pragma warning( disable : 4996)
#endif

namespace {

static auto code_to_string = [] (auto& map, auto code, const std::string& msg)
Expand Down Expand Up @@ -350,11 +346,11 @@ xrtErrorGetString(xrtDeviceHandle, xrtErrorCode error, char* out, size_t len, si
if (out_len)
*out_len = str.size() + 1;

if (!out)
if (!out || len == 0)
return 0;

auto cp_len = std::min(len-1, str.size());
std::strncpy(out, str.c_str(), cp_len);
std::memcpy(out, str.c_str(), cp_len);
out[cp_len] = 0;

return 0;
Expand Down
11 changes: 8 additions & 3 deletions src/runtime_src/core/common/api/xrt_xclbin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,10 +1748,15 @@ xrtXclbinGetXSAName(xrtXclbinHandle handle, char* name, int size, int* ret_size)
const std::string& xsaname = xclbin->get_xsa_name();
// populate ret_size if memory is allocated
if (ret_size)
*ret_size = xsaname.size();
*ret_size = xsaname.size() + 1;
Comment thread
hyunjiki-amd marked this conversation as resolved.
// populate name if memory is allocated
if (name)
std::strncpy(name, xsaname.c_str(), size);
if (!name || size == 0)
return 0;

auto cp_len = std::min(size - 1, static_cast<int>(xsaname.size()));
std::memcpy(name, xsaname.c_str(), cp_len);
name[cp_len] = 0;

return 0;
});
}
Expand Down
Loading