cmake: install FAL (xaiefal) headers alongside the driver library#1
Open
laurettaSchubert wants to merge 1 commit intoXilinx:mainfrom
Open
cmake: install FAL (xaiefal) headers alongside the driver library#1laurettaSchubert wants to merge 1 commit intoXilinx:mainfrom
laurettaSchubert wants to merge 1 commit intoXilinx:mainfrom
Conversation
Include the FAL header-only C++ wrappers in the install so that consumers using find_package(aie_codegen CONFIG) get both the C driver library and the xaiefal headers. Installed paths: include/xaiefal/common/*.hpp include/xaiefal/profile/*.hpp include/xaiefal/rsc/*.hpp include/xaiefal.hpp Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include the FAL (xaiefal) header-only C++ wrappers in the CMake install so that consumers using
find_package(aie_codegen CONFIG)get both the C driver library and the xaiefal headers.Why this is needed
The aie-codegen project already exports a proper CMake config package (
aie_codegen-config.cmake) viainstall(EXPORT). Consumers canfind_package(aie_codegen CONFIG)and link againstaie_codegen::aie_codegento get the C driver library and its headers.However, the FAL (xaiefal) C++ wrapper headers (
fal/src/) are not included in the install. Consumers that need both the C driver and the FAL C++ API (e.g. cardano'saiecompiler_client) currently have to fall back to compiling from source and staging headers manually, defeating the purpose of the config package.Adding FAL headers to the install allows these consumers to switch to
find_packageand link the pre-built library — eliminating duplicate compilation and manual header staging.Installed paths
Context
find_package(aie_codegen)with source-tree fallback🤖 Generated with Claude Code