bugfix: check for existing col_data before col switch#251
Open
HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
Open
bugfix: check for existing col_data before col switch#251HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
HimanshuChoudhary-Xilinx wants to merge 1 commit intoXilinx:main-gefrom
Conversation
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes column-switch behavior in the ASM preprocessor parser so that switching back to a previously-used column does not wipe out already-parsed col_data (e.g., when the same column is re-selected after a .include).
Changes:
- Update
asm_parser::set_current_col(int col)to only initializem_col[col]when the column entry does not already exist. - Add an explanatory comment documenting why existing
col_datamust be preserved across column switches.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
chvamshi-xilinx
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)