fix: avoid overwriting when same job number is present in same file but in different label#286
Merged
HimanshuChoudhary-Xilinx merged 1 commit intoMay 8, 2026
Conversation
…ut in different label Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates debug-report function keying to prevent function entries from being overwritten when identical job identifiers occur in the same source file across different labels/pages.
Changes:
- Include
pagenuminDebug::add_function()’s key so functions from different pages don’t collide in thefunctionsmap. - Add an explanatory comment alongside the updated key generation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| std::string add_function(uint32_t file_idx, const std::string& name, offset_type high_pc, offset_type low_pc, uint32_t col, pageid_type pagenum) { | ||
| std::string key = std::to_string(file_idx) + "_" + std::to_string(col) + "_" + name; | ||
| // source/file/column/page do not overwrite previously recorded functions. |
chvamshi-xilinx
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)