update save/restore preemption asm annotation points#287
Merged
Conversation
Signed-off-by: advanaik <AdvaitHemant.Naik@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Renumbers the annotation id values in the AIE4 preemption save/restore assembly specification files to be file-scoped (0 and 1 per file) instead of globally unique, simplifying maintenance.
Changes:
- Replaces start-annotation
idwith0and end-annotationidwith1in each preemption asm file. - Applies this consistently across all save and restore variants (1c, 1c0, 1c1, 1c2, 2c, 3c).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| specification/aie4/preemption_asm/aie4_save_1c1.asm | Renumber annotation ids 4/5 → 0/1 |
| specification/aie4/preemption_asm/aie4_save_1c2.asm | Renumber annotation ids 8/9 → 0/1 |
| specification/aie4/preemption_asm/aie4_restore_1c.asm | Renumber annotation ids 2/3 → 0/1 |
| specification/aie4/preemption_asm/aie4_restore_1c0.asm | Renumber annotation ids 2/3 → 0/1 |
| specification/aie4/preemption_asm/aie4_restore_1c1.asm | Renumber annotation ids 6/7 → 0/1 |
| specification/aie4/preemption_asm/aie4_restore_1c2.asm | Renumber annotation ids 10/11 → 0/1 |
| specification/aie4/preemption_asm/aie4_restore_2c.asm | Renumber annotation ids 2/3 → 0/1 |
| specification/aie4/preemption_asm/aie4_restore_3c.asm | Renumber annotation ids 2/3 → 0/1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
sonals
reviewed
May 14, 2026
Member
sonals
left a comment
sonals
left a comment
There was a problem hiding this comment.
Shouldn't the tables defined in src/cpp/preprocessor/aie4/aie4_save_restore_map_prebuilt.h be const?
Collaborator
|
xuhz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
update save/restore preemption asm annotation id for simplicity
make annotation id file-scoped (only 0/1 per file)
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)