update isa spec#289
Merged
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the AIE2PS ISA specification text to reflect current behavior around preemption-related jobs and LOAD_PDI, especially in multi-uC scenarios and page/job ordering semantics.
Changes:
- Clarifies
START_COND_JOB_PREEMPTbehavior and adds multi-uC/page-ordering notes. - Updates
PREEMPTdescription to describe barrier sync behavior and relaxes “whole page” requirement to “whole job (may share page)”. - Extends
LOAD_PDIdescription with hwctx-wide uniqueness constraints, page/job ordering, and multi-uC barrier sync notes.
Comments suppressed due to low confidence (1)
specification/aie2ps/isa-spec.yaml:658
- Similar to START_COND_JOB_PREEMPT, this newly added multi-uC note uses “cert”/“uc” casing that differs from other sections (e.g., “CERT”, “uC”). Please standardize the terminology here as well, and consider adding a period at the end of the sentence for consistency.
In multi-uc case, cert will do barrier sync after the load_pdi job, so each uc needs to have same number of load pdi jobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdvaitNaik
approved these changes
May 14, 2026
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Brian Xu <brianx@xilinx.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
some info in isa spec is out-of-date. update with up-to-date info.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)