Feat (dev): automate workflow #1220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomlago
force-pushed
the
feat-automate-workflow
branch
from
fc2cd7b to
edc3464
Compare
pablomlago
changed the title
Giuseppe5
reviewed
Mar 14, 2025
| @@ -263,7 +263,7 @@ def create_llm_args_parser(): | |||
| ) | |||
| parser.add_argument( | |||
| '--rotation-mode', | |||
| default='had', | |||
| default='ort', | |||
There was a problem hiding this comment.
I forgot to revert that, it was just a change to test the hook.
nickfraser
added
the
next release
pablomlago
force-pushed
the
feat-automate-workflow
branch
from
0781e31 to
7150e3e
Compare
pablomlago
force-pushed
the
feat-automate-workflow
branch
from
7150e3e to
9b14808
Compare
pablomlago
force-pushed
the
feat-automate-workflow
branch
from
9b14808 to
7150e3e
Compare
pablomlago
force-pushed
the
feat-automate-workflow
branch
from
7150e3e to
f60bd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Currently, we have to update three files (potentially per entry-point) each time an argument is added/modified/deleted, which tends to be annoying, and easy-to-forget. I feel it would improve the development experience if this process was automatized (e.g. running a single .sh to do all those updates, or even adding a custom hook to do this when committing a change to the arguments).
The following PR is not a solution, but a base point to start a conversation about this development process.
Changes Made in this PR
Testing Summary
Risk Highlight
Checklist
devbranch.