Skip to content

Fix buffer overflow in engine_status_dump() function #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix buffer overflow in engine_status_dump() function #315

wants to merge 1 commit into from

Conversation

@dmitrym1
Copy link

@dmitrym1 dmitrym1 commented Jan 17, 2025

fixes #314, also fixes a typo (INVLIAD_LEN => INVALID_LEN)

@dmitrym1 dmitrym1 mentioned this pull request Jan 17, 2025
Open
@Prandr
Copy link

Prandr commented Apr 23, 2025

@dmitrym1
Hi,
I think this all is really unnecessary. If you would like to improve the function, get rid of the messy buffer and sprintf altogether and switch to use pr_cont.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

engine_status_dump buffer overflow

2 participants

@dmitrym1 @Prandr