Skip to content

Commit 616233f

Browse files
jgmelberclaude
andcommitted
Install a modern pip cmake into the wheel-test venv
The bootgen PIE fix (#3333) is confirmed working: the shipped bootgen is now a true PIE binary and no longer segfaults during PDI generation. That unmasked a second, unrelated failure: most programming_examples/ CMakeLists.txt files require CMake >= 3.30 for their host-code build, but the self-hosted Ryzen AI runners only have system CMake 3.28.3, so `Run programming_examples against the wheel` fails uniformly with "CMake 3.30 or higher is required" once PDI generation stops being the first thing to fail. Install cmake via pip into the test venv instead of relying on the runner's system package -- same version pin already used in python/requirements_dev.txt for the from-source build path. Venv activation puts wheel-test-venv/bin ahead of the system PATH, so this shadows the outdated system cmake without needing to touch anything on the runners themselves. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent f092565 commit 616233f

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/testRocmWheelOnRyzenAI.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,12 @@ jobs:
228228
# Installs exactly like a real IRON user would (README "Install IRON"
229229
# steps), not a from-source build — this job validates the distributed
230230
# wheel artifact itself.
231+
#
232+
# Also pulls in a pip-installed cmake (same pin as
233+
# python/requirements_dev.txt): several programming_examples/
234+
# CMakeLists.txt require a newer CMake than what's on the self-hosted
235+
# runners' PATH, and this keeps the test venv self-contained instead
236+
# of depending on runner-level package upgrades.
231237
- name: Install wheel + Peano into a fresh venv
232238
shell: bash
233239
run: |
@@ -236,6 +242,7 @@ jobs:
236242
python3 -m pip install --upgrade pip
237243
python3 -m pip install dist/mlir_aie*py3-none*.whl
238244
python3 -m pip install -r utils/peano-requirements.txt
245+
python3 -m pip install "cmake>=4.3.4, <5.0"
239246
240247
- name: Run programming_examples against the wheel
241248
shell: bash

0 commit comments

Comments
 (0)