Skip to content

Commit ade6076

Browse files
authored
Apply suggestions from code review
Co-authored-by: André Rösti <androsti@amd.com>
1 parent c515d98 commit ade6076

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1674,10 +1674,7 @@ struct AIEObjectFifoStatefulTransformPass
16741674
}
16751675
}
16761676

1677-
/// Emit a UseLockOp whose lock value is a runtime-computed SSA i32. Used by
1678-
/// the dynamic objectFifo lowering, where the number of locks to
1679-
/// acquire/release is not known at compile time. Only valid for AIE2
1680-
/// semaphore locks (the dynamic lowering targets AIE2/AIE2p).
1677+
/// Emit a UseLockOp whose lock value is a runtime-computed SSA i32.
16811678
void createUseLocksRuntime(OpBuilder &builder, ObjectFifoCreateOp op,
16821679
ObjectFifoPort port, Value count,
16831680
LockAction lockAction, ObjectFifoState &state) {
@@ -2337,8 +2334,7 @@ struct AIEObjectFifoStatefulTransformPass
23372334
//===----------------------------------------------------------------===//
23382335
// For tiles using the dynamic objectFifo lowering, the number of locks
23392336
// to acquire is computed at runtime from a per-(fifo,port) "held" counter
2340-
// stored in a local buffer. This replaces the static (cyclostatic)
2341-
// accounting that cannot see through runtime-dependent control flow.
2337+
// stored in a local buffer.
23422338
// Runtime lock counts require semaphore locks (AIE2+); on architectures
23432339
// with binary locks (AIE1) the dynamic lowering keeps static lock counts.
23442340
bool isDynamicCore = dynamicLoweringTiles.count(coreOp.getTileOp()) > 0 &&

0 commit comments

Comments
 (0)