Address Copilot review comments

- Guard the new -fPIC/-fPIE blocks with NOT MSVC too: clang-cl reports
  CMAKE_CXX_COMPILER_ID "Clang" but uses the MSVC-style driver, which
  doesn't accept these GNU-style flags.
- Drop -fPIE from target_link_options(bootgen ...); it's a compile-only
  flag, and passing it at link time can break toolchains where linking
  doesn't go through the compiler driver. Only -pie belongs there.

Re-verified locally under the same forced -fno-pie -fno-PIC -no-pie
global configuration as before: bootgen still links as a true PIE
(ET_DYN) binary and runs correctly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: jgmelber

tools/bootgen/CMakeLists.txt

@@ -144,16 +144,12 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
   target_compile_options(bootgen-lib PRIVATE /wd4996 /wd4840 /wd4005 /wd5033)
 endif()
 target_compile_options(bootgen-lib PRIVATE ${bootgen_warning_ignores})
-if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
-  # Explicit -fPIC, not just the POSITION_INDEPENDENT_CODE property above:
-  # that property relies on CMake's CMP0083 + the CheckPIESupported module
-  # to inject the right compiler/linker flags, and this project never calls
-  # check_pie_supported(), so the property silently does nothing on some
-  # toolchains (observed on the manylinux_2_28 gcc-toolset used to build
-  # release wheels, which -- unlike a distro's system gcc -- does not
-  # default to PIE/PIC either). Passed last so it wins (compilers apply
-  # "last flag wins" for -fPIC/-fno-PIC) over anything inherited from the
-  # linked MLIR/LLVM package's own build configuration.
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU" AND NOT MSVC)
+  # The POSITION_INDEPENDENT_CODE property above doesn't reliably force PIC
+  # here (this project never calls check_pie_supported(), which CMP0083
+  # needs), so pass -fPIC explicitly, last, so it wins over any inherited
+  # -fno-PIC. NOT MSVC excludes clang-cl, which also matches "Clang" but
+  # can't parse this flag.
   target_compile_options(bootgen-lib PRIVATE -fPIC)
 endif()
 target_include_directories(bootgen-lib PRIVATE ${BOOTGEN_SOURCE} ${OPENSSL_INCLUDE_DIR})
@@ -178,14 +174,11 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
   target_compile_options(bootgen PRIVATE /EHsc)
   target_compile_options(bootgen PRIVATE /wd4996 /wd4840 /wd4005 /wd5033)
 endif()
-if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
-  # Explicit -fPIE/-pie (see bootgen-lib above for why the
-  # POSITION_INDEPENDENT_CODE property alone can't be trusted). Passed last
-  # so it wins -- compilers apply "last flag wins" for -fPIE/-fno-PIE and
-  # -pie/-no-pie -- over anything inherited from the linked MLIR/LLVM
-  # package's own build configuration.
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU" AND NOT MSVC)
+  # See bootgen-lib above. -fPIE is compile-only; -pie is the link-mode
+  # switch (kept separate since some toolchains don't accept -fPIE at link).
   target_compile_options(bootgen PRIVATE -fPIE)
-  target_link_options(bootgen PRIVATE -fPIE -pie)
+  target_link_options(bootgen PRIVATE -pie)
 endif()
 target_compile_definitions(bootgen PRIVATE OPENSSL_USE_APPLINK)
 target_link_libraries(bootgen PRIVATE bootgen-lib OpenSSL::SSL OpenSSL::applink)