Skip to content

Conversation

gzliudan
Copy link
Collaborator

Proposed changes

fix audit issue XFN-40: Sleeping While Holding Multiple Mutex Locks Could Stalls Event Loop And Miner Operations

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title miner: not sleep if locks multiple mutex, close XFN-40 miner: fix lock-hold starvation risk, close XFN-40 Oct 15, 2025
@gzliudan gzliudan changed the title miner: fix lock-hold starvation risk, close XFN-40 miner: fix multiple mutex starvation risk, close XFN-40 Oct 15, 2025
@gzliudan gzliudan changed the title miner: fix multiple mutex starvation risk, close XFN-40 miner: not sleep when hold multiple mutex, close XFN-40 Oct 15, 2025
@benjamin202410
Copy link
Collaborator

I prefer not to change logic here

  1. non-buffered go routine is easily get deadlock if it's not well consider
  2. current sleep code is there for so long and working fine

@gzliudan gzliudan force-pushed the fix-XFN-40 branch 2 times, most recently from 550932f to 82f61bb Compare October 16, 2025 02:44
@gzliudan
Copy link
Collaborator Author

I prefer not to change logic here

  1. non-buffered go routine is easily get deadlock if it's not well consider
  2. current sleep code is there for so long and working fine

resetCh is buffered go routine:

resetCh:        make(chan time.Duration, 1),

@gzliudan
Copy link
Collaborator Author

I switched back to the previous version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants