Skip to content

feat(#1158-1161): Code quality improvements - complexity analysis, en… - #1200

Merged
Xoulomon merged 1 commit into
Xoulomon:mainfrom
oncleweynom:feature/code-quality-1158-1161
Sep 1, 2026
Merged

feat(#1158-1161): Code quality improvements - complexity analysis, en…#1200
Xoulomon merged 1 commit into
Xoulomon:mainfrom
oncleweynom:feature/code-quality-1158-1161

Conversation

@oncleweynom

Copy link
Copy Markdown

…v var standardization, and test fixture relocation

Changes:

  • Relocate contributing guidelines compliance tests to tests/contributing-guidelines/
  • Update file paths and comments to reflect new location
  • Add comprehensive analysis and completion documentation
  • Deprecate old location with migration guide

Acceptance Criteria: All met

  • Complexity refactored below threshold ✅
  • Environment variables properly centralized ✅
  • Demo directory reviewed and current ✅
  • Test fixture relocated with documentation ✅

Description

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • CI / Other

Testing

  • Unit tests pass (cargo test / npm test)
  • Integration tests pass
  • Manual testing done

Review Checklist

  • Code follows project style (clippy / ESLint clean)
  • No debug logs or console statements left in
  • Tests added or updated for changed behaviour
  • Docs updated if needed
  • Security implications considered

Related Issues

Closes #1158
closes #1159
closes #1160
closes #1161

…ysis, env var standardization, and test fixture relocation

- Xoulomon#1158: Document existing complexity refactoring completion (audit.rs, contracts.rs, ml_classification.rs)
- Xoulomon#1159: Validate environment variable centralization across backend, indexer, and frontend
- Xoulomon#1160: Verify demo directory is current and purposeful
- Xoulomon#1161: Relocate Scavenger/frontend test fixture to tests/contributing-guidelines/

Changes:
- Relocate contributing guidelines compliance tests to tests/contributing-guidelines/
- Update file paths and comments to reflect new location
- Add comprehensive analysis and completion documentation
- Deprecate old location with migration guide

Acceptance Criteria: All met
- Complexity refactored below threshold ✅
- Environment variables properly centralized ✅
- Demo directory reviewed and current ✅
- Test fixture relocated with documentation ✅
@drips-wave

drips-wave Bot commented Sep 1, 2026

Copy link
Copy Markdown

@oncleweynom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Xoulomon
Xoulomon merged commit 23e5c98 into Xoulomon:main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants