Skip to content

Resolve "Create XS Standard Library" #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Resolve "Create XS Standard Library" #382

wants to merge 3 commits into from

Conversation

Kfeavel
Copy link
Member

@Kfeavel Kfeavel commented Feb 13, 2022

Resolves #378

@Kfeavel Kfeavel self-assigned this Feb 13, 2022
@Kfeavel Kfeavel force-pushed the 378-xyris-standard-library branch 2 times, most recently from 6ab24f8 to 52f62da Compare February 13, 2022 23:23
@Kfeavel Kfeavel force-pushed the 378-xyris-standard-library branch from 52f62da to c27103d Compare February 21, 2022 01:27
jamesaorson
jamesaorson requested changes Jan 3, 2023
View reviewed changes
Kernel/SConscript
@@ -6,6 +6,10 @@ env = env.Clone()
linkerscript = env.File('Arch/$ARCH/linker.ld')
env.Append(
LINKSCRIPT=linkerscript,
CPPDEFINES={
'__xyris__': None,
'_kernel__': None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a leading underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesaorson jamesaorson jamesaorson requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Kfeavel Kfeavel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create XS Standard Library
2 participants
@Kfeavel @jamesaorson