[Fix/#12] ktlint적용시 어노테이션이 붙은 생성자에 대해 자동 줄바꿈을 하던 부분 수정#13
Merged
Conversation
|
""" Walkthrough
Changes
Sequence Diagram(s)(해당 변경은 설정 및 버전 변경에 국한되어 있으므로 시퀀스 다이어그램 생략) Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.editorconfig (1)
16-16:ktlint_standard_annotation = disabled추가는 올바르지만, 하위 버전 호환성도 고려하세요
ktlint0.48+ 계열에서는ktlint_<ruleset>_<rule>형식(예:ktlint_standard_annotation)으로 규칙을 끄는 방식이 맞습니다. 다만 레거시(11.x) 플러그인을 병행 사용하거나, CI 캐시 등에 구버전 ktlint가 남아 있을 경우 속성이 무시돼 다시 포맷이 깨질 수 있습니다.
- 구버전 호환이 필요하면
ktlint_disabled_rules=annotation방식도 병행 기재를 검토해보세요.- 팀 전체가 12.0.0+로 통일됐는지 한 번 더 확인을 권장드립니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.editorconfig(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
.editorconfig (1)
15-15:ktlint_function_naming_ignore_when_annotated_with설정 유지 확인 완료
기존 설정이 그대로 유지되어,@Composable함수의 네이밍 검사 예외가 정상 동작할 것으로 보입니다. 별다른 문제 없습니다.
Contributor
Author
|
ktlint_code_style=android_studio 적용시 아래처럼 인터페이스, 들여쓰기 관련 추상 클래스를 명시할 때 기존 스타일과 다른 부분이 존재합니다. @HiltViewModel
class HomeViewModel @Inject constructor(
savedStateHandle: SavedStateHandle,
initState: HomeState,
) : MviViewModel<HomeState, HomeSideEffect, HomeIntent>(
initState,
savedStateHandle,
), // <- 여기
HomeSampleInterface {
override suspend fun SimpleSyntax<HomeState, HomeSideEffect>.reduceState(
intent: HomeIntent,
state: HomeState,
): HomeState? {
TODO("Not yet implemented")
}
}
위 옵션을 disable하는 방법을 찾지 못해 일단 이전 버전 11.3.2 로 사용하기로 했습니다. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ PR Content ]
ktlint 적용시 Inject와 같은 어노테이션이 붙은 생성자에 대해 자동 줄바꿈을 하던 문제를 수정했습니다.
Related issue
Screenshot 📸
x
Work Description
To Reviewers 📢
Summary by CodeRabbit
Summary by CodeRabbit