Skip to content

[Style] 프로필 사진 변경 기능 사용성 확보 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Remaked-Swain wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[Style] 프로필 사진 변경 기능 사용성 확보 #205

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a66aa8
[Style] #204 - 프로필 사진 변경 기능 사용성 확보
Remaked-Swain Apr 8, 2026
5286ff7
[Fix] #204 - 프로필 편집 후 아카이빙 탭이 나타나는 문제 해소
Remaked-Swain Apr 8, 2026
4961d0c
[Chore] #204 - 더미 유저정보 추가
Remaked-Swain Apr 8, 2026
c75da04
[Refactor] #204 - 유저 로그인 세션 주입방식 변경
Remaked-Swain Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions Neki-iOS/Features/MyPage/Sources/Presentation/Sources/View/AccountPreferenceView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,20 @@ private extension AccountPreferenceView {

var profileArea: some View {
VStack(spacing: 16) {
KFImage(store.user.profileImageURL)
.resizable()
.onFailureImage(.iconDefaultProfile)
.scaledToFill()
.frame(width: 142, height: 142)
.clipShape(.circle)
ZStack(alignment: .bottomTrailing) {
KFImage(store.user.profileImageURL)
.resizable()
.onFailureImage(.iconDefaultProfile)
.scaledToFill()
.frame(width: 142, height: 142)
.clipShape(.circle)

Button {
store.send(.editProfileButtonTapped)
} label: {
Comment on lines +80 to +82
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether editProfileButtonTapped routes directly to image picking
# or just navigates to profile edit screen.

fd -i 'AccountPreferenceFeature.swift' --exec sed -n '1,260p' {}
rg -n -C4 '\beditProfileButtonTapped\b' --type swift
rg -n -C4 '\b(profile|camera|image|picker|photo)\b' --type swift

Repository: YAPP-Github/Neki-iOS

Length of output: 50376

카메라 버튼이 프로필 편집 화면을 거쳐 기대되는 직접 사진 변경 플로우를 구현하지 못합니다.

Line 81의 .editProfileButtonTapped 액션은 MyPageCoordinator.swift:49–50에서 .profileEdit(.init(user: state.root.user))로 라우팅되어, 결과적으로 프로필 편집 화면으로 네비게이션됩니다. 이는 Line 93의 닉네임 편집(연필 아이콘)과 동일한 플로우입니다. 따라서 카메라 버튼은 "바로 사진 변경" 기능이 아니라 기존 편집 화면을 거치게 됩니다. 카메라 선택을 위해 별도의 액션(editProfileImageButtonTapped 등) 및 라우팅 경로를 추가하여 구현하시기 바랍니다.

추가로 Line 83의 이미지 버튼은 명시적 접근성 레이블 없이 아이콘만 표시되어, VoiceOver 사용자 경험이 저하될 수 있습니다. .accessibilityLabel("프로필 사진 변경") 등의 수정자를 추가하세요.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@Neki-iOS/Features/MyPage/Sources/Presentation/Sources/View/AccountPreferenceView.swift`
around lines 80 - 82, The camera/image Button currently sends
store.send(.editProfileButtonTapped) which routes via MyPageCoordinator to
.profileEdit(...) and thus opens the full profile edit screen (same as the
nickname pencil), so change the flow by adding a distinct action (e.g.
editProfileImageButtonTapped) to the action enum and reducer, update the Button
to send that new action, and add a new coordinator route/handling for the
image-only flow (e.g. profileImageEdit or a direct image picker entry) in
MyPageCoordinator where you previously route .profileEdit(.init(user:
state.root.user)); also add an accessibility label to the image button (e.g.
.accessibilityLabel("프로필 사진 변경")) to improve VoiceOver support.

Copy link
Copy Markdown
Member Author

@Remaked-Swain Remaked-Swain Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도한 사항이므로 기각.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Remaked-Swain, 이해했습니다. PR 설명에서도 해당 이중 탭 흐름(계정 설정 화면 → 프로필 편집 화면 → 프로필 변경)이 의도적으로 허용된 동작임을 명시하셨군요. 감사합니다!

(╯°□°）╯

Image(.iconProfileCamera)
}
Comment on lines +80 to +84
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify accessibility metadata presence for the new camera button area.
rg -n -C3 'iconProfileCamera|accessibilityLabel|accessibilityHint|minWidth:\s*44|minHeight:\s*44' --type swift

Repository: YAPP-Github/Neki-iOS

Length of output: 1728

🏁 Script executed:

# Read the full context around the button in AccountPreferenceView.swift
cat -n Neki-iOS/Features/MyPage/Sources/Presentation/Sources/View/AccountPreferenceView.swift | sed -n '70,95p'

Repository: YAPP-Github/Neki-iOS

Length of output: 1163

카메라 버튼의 접근성(VoiceOver 라벨/탭 영역) 개선이 필요합니다.

이미지 단독 버튼은 의미 전달이 약하고 탭 타깃이 작을 수 있습니다. 최소 탭 영역(44pt)과 접근성 라벨/힌트를 추가해주세요.

개선 예시 
                Button {
                    store.send(.editProfileButtonTapped)
                } label: {
                    Image(.iconProfileCamera)
+                        .padding(10)
+                        .background(.white)
+                        .clipShape(Circle())
                }
+                .frame(minWidth: 44, minHeight: 44)
+                .contentShape(Rectangle())
+                .accessibilityLabel("프로필 사진 변경")
+                .accessibilityHint("프로필 사진을 변경하는 화면으로 이동")
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@Neki-iOS/Features/MyPage/Sources/Presentation/Sources/View/AccountPreferenceView.swift`
around lines 80 - 84, The camera Image button (Button sending
store.send(.editProfileButtonTapped) with Image(.iconProfileCamera)) lacks
accessible labeling and a minimum tappable area; update the Button to provide an
accessibilityLabel (e.g., "Edit profile photo"), an accessibilityHint (e.g.,
"Opens camera to change your profile picture"), ensure it has
.accessibilityAddTraits(.isButton), and enlarge its tap target by applying a
minimum frame (frame(minWidth: 44, minHeight: 44)) or additional padding plus
contentShape(Rectangle()) so the hit area meets 44pt minimum while keeping the
existing action and image.

Copy link
Copy Markdown
Member Author

@Remaked-Swain Remaked-Swain Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

당장은 접근성 관련 리팩토링을 진행할 예정이 없으므로 기각.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Remaked-Swain, 알겠습니다. 나중에 접근성 개선을 진행하실 때 참고할 수 있도록 이슈로 남겨드릴까요?

(´･ω･`)

}

HStack(spacing: 9) {
Text(store.user.nickname)
Expand Down