Skip to content

[FEAT] 애드몹 배너를 삽입합니다. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 19, 2025

Conversation

DongChyeon
Copy link
Member

Related issue 🛠

closed #210

어떤 변경사항이 있었나요?

  • 🐞 BugFix Something isn't working
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (Junit, etc.)

CheckPoint ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • PR 컨벤션에 맞게 작성했습니다. (필수)
  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕) (필수)
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다. (필수)
  • BugFix의 경우, 버그의 원인을 파악하였습니다. (선택)

Work Description ✏️

image

  • debug, release 환경에 따라 테스트 광고, 실 광고를 다르게 띄워주도록 처리했습니다.
  • 알람 해제 화면 상단에 배너 광고를 추가했습니다.

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

필요한 local.properties 값은 노션에 올려두었습니다~~

@DongChyeon DongChyeon force-pushed the feature/#210-add-admob-banner branch from ccebf16 to 1e33cc5 Compare April 19, 2025 06:41
Copy link
Contributor

@MoonsuKang MoonsuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!!
buildTypes 같은 경우는 buildlogic에서 ConventionPlugin으로도 처리할 수 있을 것 같은데 어떻게 생각하시는 지 궁금 합니다잉

@DongChyeon
Copy link
Member Author

수고하셨습니다~!! buildTypes 같은 경우는 buildlogic에서 ConventionPlugin으로도 처리할 수 있을 것 같은데 어떻게 생각하시는 지 궁금 합니다잉

방금 했다옹

Copy link
Contributor

@MoonsuKang MoonsuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예아 좋습니다~
SHOOT

@DongChyeon DongChyeon merged commit 72be674 into develop Apr 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 애드몹 배너를 삽입합니다.
2 participants