Song metadata refactor#272
Draft
shadowflower64 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor of the SongMetadata FillFromIni function, it replaces the repeated function calls with one generic function. This improves the readability and maintainability of the FillFromIni function.
@TheNathannator has noted that this change may affect performance negatively, so this PR needs to be tested in terms of performance before being accepted into the main repo. These functions use the
[MethodImpl(MethodImplOptions.AggressiveInlining)]attribute which should theoretically make the methods inlined, but still it needs to be tested.