Skip to content

Add ability to view the score screen for a replay#1488

Open
Supersonicboss1 wants to merge 7 commits into
YARC-Official:devfrom
Supersonicboss1:view-score-screen-from-replay
Open

Add ability to view the score screen for a replay#1488
Supersonicboss1 wants to merge 7 commits into
YARC-Official:devfrom
Supersonicboss1:view-score-screen-from-replay

Conversation

@Supersonicboss1

@Supersonicboss1 Supersonicboss1 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Things I have changed in this PR that are not obvious from the title:

  • Analyze has been banished to test builds and the editor, and therefore removed from nightly.
  • AverageMultiplier is no longer a parameter needed to create the score screen, as it should be present in BaseStats.
  • This uses ReplayAnalyzer to generate more detailed information about the replay. You might be able to get it from the replay directly, but this was simpler and didn't require a super significant rewrite of anything to accomplish. If you don't like this approach, let me know and I'll find another way to do it.
  • You can view a replay from the replay score screen. I considered removing the view replay button entirely, and making viewing the score screen the default (green option), and then you press yellow from a replay score screen to view, but I left that unchanged for now.

I should note, this only lets you view the score cards of replays where you could watch them, that is, where the chart is present and the replay version is current. I would like to change this to not require that, but it would require building a subset of both the score screen and score cards which only includes data that is present in replays, and it would have no background image which sucks.

Requires YARC-Official/YARG.Core#380

Comment thread Assets/Script/Menu/History/ViewTypes/ReplayViewType.cs Outdated

@wyrdough wyrdough left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I think merits discussion: Should we refuse to generate score cards for replays that don't pass validation?

@Supersonicboss1

Copy link
Copy Markdown
Contributor Author

One thing I think merits discussion: Should we refuse to generate score cards for replays that don't pass validation?

I would say no, or at least not now? Right now, there is a fair number of replays which don't pass validation, but where the score is still reasonably "correct" (e.g. it's just some tiny difference with star power time stuff), and I wouldn't want users to be unable to view the scores of these replays, even if they may be slightly off. Maybe it would be better if we just showed the inconsistent replay results popup (or one similar to it, but specific to viewing the score screen on a replay)?

@poliwhirlge

Copy link
Copy Markdown
Contributor

late to this but imo don't even need to bring the inconsistent popup again, just add another little pill thing up in the top right with "INCONSISTENT REPLAY" in it where we usually have "SCORE NOT SAVED"

…-replay

# Conflicts:
#	Assets/Script/Menu/ScoreScreen/ScoreScreenMenu.cs
- Also fix some replay loading stuff
- Also some localization, needs more
@Supersonicboss1

Copy link
Copy Markdown
Contributor Author

late to this but imo don't even need to bring the inconsistent popup again, just add another little pill thing up in the top right with "INCONSISTENT REPLAY" in it where we usually have "SCORE NOT SAVED"

Sorry for taking an entire month to get to this lol, but yeah, that's a better idea, so I've implemented it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants