Add ability to view the score screen for a replay#1488
Conversation
wyrdough
left a comment
wyrdough
left a comment
There was a problem hiding this comment.
One thing I think merits discussion: Should we refuse to generate score cards for replays that don't pass validation?
I would say no, or at least not now? Right now, there is a fair number of replays which don't pass validation, but where the score is still reasonably "correct" (e.g. it's just some tiny difference with star power time stuff), and I wouldn't want users to be unable to view the scores of these replays, even if they may be slightly off. Maybe it would be better if we just showed the inconsistent replay results popup (or one similar to it, but specific to viewing the score screen on a replay)? |
|
late to this but imo don't even need to bring the inconsistent popup again, just add another little pill thing up in the top right with "INCONSISTENT REPLAY" in it where we usually have "SCORE NOT SAVED" |
…-replay # Conflicts: # Assets/Script/Menu/ScoreScreen/ScoreScreenMenu.cs
- Also fix some replay loading stuff - Also some localization, needs more
Sorry for taking an entire month to get to this lol, but yeah, that's a better idea, so I've implemented it here. |
3 participants
Things I have changed in this PR that are not obvious from the title:
I should note, this only lets you view the score cards of replays where you could watch them, that is, where the chart is present and the replay version is current. I would like to change this to not require that, but it would require building a subset of both the score screen and score cards which only includes data that is present in replays, and it would have no background image which sucks.
Requires YARC-Official/YARG.Core#380