Basic Streak Counter#1490
Open
ZeeVonLeit wants to merge 29 commits into
Open
Conversation
This is it.
Author
|
PS: This is a pre alpha. |
theli-ua
reviewed
May 14, 2026
theli-ua
left a comment
theli-ua
left a comment
Contributor
There was a problem hiding this comment.
PS: This is a pre alpha.
Should this be a draft then?
Comment on lines
+8
to
+15
| /// <summary> | ||
| /// Create a TMP cache of all available multiplier texts. | ||
| /// </summary> | ||
| /// <param name="maxMultiplier">The max multiplier to generate WITHOUT Star Power.</param> | ||
| /// <param name="ComboTextPrefab">The prefab of the text to instantiate.</param> | ||
| /// <param name="isMultiplayer"> Whether we are playing multiplayer (and therefore do not need to generate SP multipliers).</param> | ||
| /// <typeparam name="T">TextMeshPro type being used</typeparam> | ||
| /// <returns>Array where the corresponding TMP object is at arr[multiplier - 2]</returns> |
Contributor
There was a problem hiding this comment.
This comment is wrong
Besides, you're not even using this anywhere
Comment on lines
+101
to
+105
|
|
||
| //public void ComboUpdate(int combo) | ||
| //{ | ||
|
|
||
| //} |
| _multiplierText.text = string.Empty; | ||
| _textCache = MultiplierTextHelper.CreateMultiplierTextCache(maxMultiplier, _multiplierText, isMultiplayer); | ||
|
|
||
Contributor
There was a problem hiding this comment.
There's quite a few of these spurious whitespace changes
Author
There was a problem hiding this comment.
I just put it on draft for now.
Set the combo text directly in ComboMeter (_comboText.SetText("{0} COMBO", combo)) and keep sprite index/material updates. Remove the unused ComboTextHelper (and its .meta) which cached/generated TMP combo texts, and clean up leftover commented code. Simplifies combo update path and removes an unused/buggy helper.
Many Things
Author
|
The only missing thing is to toggle. |
Author
|
Streak enable is experimental
Author
|
Since I added the Streak Counter option which can be found in the Experimental Settings. I think were ready to go. If needed. |
Author
|
Note: The Localization for Streak Counter option is not yet invented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added combo for each track player.