Add Tournament Engine#1539
Open
Ape wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new Tournament Engine. This has been a long-standing wishlist item for me and many other players. The engine is intented for players who care about competitive precision playing. Unlike any of the existing engines, this one can easily separate high-level players even on songs where they are likely to full combo.
This PR is my take on this feature. I have been play testing this implementation and I think it fits my ideal vision well. I'm open to comments of course!
This engine is not available on vocals since I don't even know what it would do there.
Needs accompanying Core PR YARC-Official/YARG.Core#407.
Details
Star power is disabled
Score is based on timing accuracy
The scoring percentage is based on the score
Multiplier (1x..4x) is unchanged
Some people have called out for removing the multiplier for competitive play, but I think it's still an effective and important way to punish overhits / overstrums.
We could consider limiting the multiplier to go up to 2x only.
In-song accuracy indicator will be implemented separately
We will need some way to visualize the timing accuracy during play, but that's out of scope of this PR and can be done separately.
Implications in practice
For songs that I could previously get around 99.7%, I can get something around 90% in Tournament Engine.
With this engine it's possible to FC with a score like 95%. That's fine. FC remains a motivating achievement.
Related discussion