Skip to content

Fix bug where engine preset is not set correctly when switching game modes in the Profiles menu #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poliwhirlge wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −1
Open

Fix bug where engine preset is not set correctly when switching game modes in the Profiles menu #1554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Assets/Script/Menu/ProfileList/ProfileSidebar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public void UpdateSidebar(YargProfile profile, ProfileView profileView)
_rangeDisabledToggle.isOn = profile.RangeEnabled;
_openLaneDisplayTypeDropdown.value = _openLaneDisplayTypesByIndex.IndexOf(profile.OpenLaneDisplayType);
_useCymbalModelsToggle.isOn = profile.UseCymbalModels;

// Update preset dropdowns
_engineDropdown.SetValueWithoutNotify(
_enginePresetsByIndex.IndexOf(profile.EnginePreset));
Expand All @@ -270,6 +270,12 @@ public void UpdateSidebar(YargProfile profile, ProfileView profileView)
_rockMeterPresetDropdown.SetValueWithoutNotify(
_rockmeterPresetsByIndex.IndexOf(profile.RockMeterPreset));

// Not all game modes support all engine presets.
// If the current engine doesn't exist for the selected instrument, the above _engineDropdown
// will be silently set to index 0, but the engine itself will not have been set, so we need
// to explicitly set it.
ChangeEngine();

// Show the proper name container (hide the editing version)
_nameContainer.SetActive(true);
_editNameContainer.SetActive(false);
Expand Down