Improved song sync 2.0 now with even more improvement#1558
Draft
polson wants to merge 31 commits into
Draft
Conversation
77f18d2 to
01c8ce9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Song sync improvements
This improves song synchronization to be faster and more accurate. Works with a 5000ms buffer without oscillation.
In addition we fix meteronome sync to line up more accurately with the beatlines with a new BassOneShotChannel class. This class uses a DSP to schedule the playback of a pre-loaded oneshot sample (ie metronome sound). It also handles the rescheduling necessary upon time and tempo changes. We also introduce a MetronomeScheduler class that schedules these all at once.
Linux testing TBD.
Example video with 2000 ms buffer
CleanShot.2026-07-11.at.17.29.42.mp4
Changes