Open
Conversation
…onfiguration parameters, and include new documentation.
…prehensive setup documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the YDLidar ROS2 driver for full compatibility with ROS2 Jazzy, improves documentation, and corrects configuration for the X4 Pro (S2PRO) lidar. The most important changes include refactoring parameter handling in the C++ driver code, updating launch files and configuration for Jazzy conventions, fixing QoS settings for RViz2, and providing a comprehensive setup guide.
ROS2 Jazzy Compatibility
src/ydlidar_ros2_driver_node.cppto use the new ROS2 Jazzy API, removing deprecated Humble patterns and ensuring default values are set inline.CMakeLists.txtfrom C++14 to C++17, as required by ROS2 Jazzy.launch/ydlidar_launch.py,launch/ydlidar_launch_view.py) to use Jazzy-compatible arguments: replacednode_executable,node_name, andnode_namespacewithexecutable,name, andnamespace, and updated static transform publisher arguments to the new format. [1] [2] [3]Configuration and Documentation
lidarKnowhow.md, including hardware quirks, configuration tips, and common pitfalls for the X4 Pro/S2PRO.params/ydlidar.yamlto reflect correct settings for the S2PRO protocol (single channel, baudrate, sample rate, etc.), with comments explaining each parameter.Visualization and QoS
Best Effortinconfig/ydlidar.rviz, ensuring scan data is visible in RViz2.Versioning and Metadata
1.0.2-jazzyinsrc/ydlidar_ros2_driver_node.cppfor clarity and traceability.