Remove Liquid checks for 1.12.2#5
Open
bc-185 wants to merge 1 commit into
Open
Conversation
Removes an if statement that existed prior to 1.13 that effectively acted as a pair of scissors cutting out portions of the stronghold located near water or lava if they were not the portal room.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to 1.13, there was a series of if statements in the stronghold's generation code that effectively acted as a pair of scissors cutting out portions of the stronghold that were located near water (such as the upper portion of an ocean biome) or lava (such as the lava that replaces air blocks in caves at low altitudes). This contribution attempts to remove that behavior so that the stronghold is not missing pieces in such area(s).
