layout/monitor: round workspace render geo to physical pixels #3299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Good catch but the problem is actually deeper. All components of the position are already rounded to physical pixels, but the final coordinate ends up very very slightly off due to floating-point rounding. I'm thinking what's the best fix here is and what other places could be affected. |
Owner
|
Specifically, in this case, the cursor y is 0 and the workspace y is 0.0000000000002 |
Owner
|
Thanks. I added a clarifying comment and a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3298.
The workspace render rectangles could end up at fractional physical positions, causing a mismatch near the edge.
This PR rounds the workspace origin to physical pixels using existing helpers:
to_physical_precise_round(scale).to_logical(scale).