Skip to content

Bump the rust-dependencies group with 2 updates #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Bump the rust-dependencies group with 2 updates #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion wl-clipboard-rs-tools/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ keywords.workspace = true
categories = ["command-line-utilities"]

[dependencies]
anyhow = "1.0.96"
anyhow = "1.0.97"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you do this? Does wl-clipboard-rs somehow hard-require some changes made in a patch release? Nor am I seeing this PR changing anything in the code that would introduce such a requirement?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test the project before releasing, cargo will resolve the latest dependency versions. Therefore, I make my Cargo.toml reflect the versions that I tested against.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What you're describing is Cargo.lock (also updated in this PR), whereas Cargo.toml lists version requirements. See the docs.
  • If anything, the version you have tested against is 1.0.96 (or an older one), not 1.0.97 as bumped here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I primarily test right before tagging a new release. I also bump all dependencies before tagging a new release and testing it. However, it's easier to catch regressions when bumping versions one by one like this as they come out rather than all at once before release, because I am running the git code on my system, so there's more of a chance of me or someone else stumbling into a regression.

If I understand right, you want me to not bump at all, but I'm always bumping for the release, and given that, it's better to bump right away than wait until the release day.

clap = { version = "4.5.31", features = ["derive", "wrap_help"] }
libc.workspace = true
log.workspace = true
Expand Down
Loading