Skip to content

Django 1.6 compatbility and some other small changes#3

Open
MaZZly wants to merge 5 commits intoYaco-Sistemas:masterfrom
malthejorgensen:master
Open

Django 1.6 compatbility and some other small changes#3
MaZZly wants to merge 5 commits intoYaco-Sistemas:masterfrom
malthejorgensen:master

Conversation

@MaZZly
Copy link

@MaZZly MaZZly commented Sep 19, 2014

No description provided.

Building the `Last-Translator` string fails if the User class doesn't
have `first_name`, `last_name` or `email`.
We pass building the data if a UnicodeDecodeError occurs. I think we can
skip building these data when a custom User class is being used as well
(for now).
Use classes only to assign Javascript functionality to the
“See translatable items”, “See non translated items” and
“Apply changes” buttons.
@MaZZly
Copy link
Author

MaZZly commented Sep 19, 2014

Seems like @malthejorgensen has created some nice improvements (esp for Django 1.6 compatibility, which is currently lacking)

@MaZZly
Copy link
Author

MaZZly commented Sep 23, 2014

@goinnn Could you guys merge this and put it to pypi updated? I run into problems all the time with installing from @malthejorgensen git with pip requirements file.

@malthejorgensen
Copy link

What kind of problems?

@MaZZly
Copy link
Author

MaZZly commented Sep 23, 2014

Sorry was a bit unclear there.. Your changes are working well =)
My problem:
pip install -r requirements.txt doesn't seem to install from the git-repo, instead it takes the pypi version that is not django1.6 compatible.. Have to manually do pip install git+https://... every place where i deploy

@malthejorgensen
Copy link

You can have a line in your requirements.txt that looks like this:

git+git://github.com/malthejorgensen/django-inlinetrans.git#egg=django-inlinetrans

@MaZZly
Copy link
Author

MaZZly commented Sep 24, 2014

Seems as if my pip freeze doesn't really do it that way.. instad adds django-inlinetrans-master which will ultimately fail..

@malthejorgensen
Copy link

You can edit requirements.txt (the output of pip freeze) manually and replace the line with django-inlinetrans with

git+git://github.com/malthejorgensen/django-inlinetrans.git#egg=django-inlinetrans

or if you want to automate it

pip freeze | sed 's%.*inlinetrans.*%git+git://github.com/malthejorgensen/django-inlinetrans.git#egg=django-inlinetrans%'

@goinnn
Copy link
Member

goinnn commented Sep 24, 2014

I'll try to see it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants