fix: update dependencies in maxmind#1723
Merged
YamatoSecurity merged 5 commits intomainfrom Dec 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the maxminddb dependency from version 0.26.0 to 0.27.0 and adapts the GeoIP lookup code to the new API. The primary changes involve updating how IP geolocation data is decoded and accessed.
- Migrated from direct type lookup to a two-step decode pattern for GeoIP lookups
- Updated field access from
names.get("en")tonames.englishfor localized names - Updated multiple dependencies (syn, bytes, clap, hashbrown, etc.) to their latest versions
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/options/geoip_search.rs | Adapts GeoIP lookup code to maxminddb 0.27.0 API, using new decode pattern and updated field access methods |
| Cargo.lock | Updates maxminddb from 0.26.0 to 0.27.0 and updates various other dependencies (syn, bytes, clap, hashbrown, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
{
"Timestamp": "2019-08-03 22:50:29.101 +09:00",
"RuleTitle": "Net Conn",
"Level": "info",
"Computer": "MSEDGEWIN10",
"Channel": "Sysmon",
"EventID": 3,
"RecordID": 5521,
"Details": {
"Initiated": true,
"Proto": "tcp",
"SrcIP": "10.0.2.15",
"SrcPort": 50105,
"SrcHost": "MSEDGEWIN10.home",
"TgtIP": "185.199.111.153",
"TgtPort": 443,
"TgtHost": "",
"User": "MSEDGEWIN10\\IEUser",
"Proc": "C:\\Windows\\System32\\mmc.exe",
"PID": 4372,
"PGUID": "747F3D96-9123-5D45-0000-001087596101",
"SrcASN": "Private",
"TgtASN": "FASTLY",
"TgtCountry": "United States",
"TgtCity": ""
},
"ExtraFieldInfo": {
"DestinationIsIpv6": false,
"DestinationPortName": "https",
"SourceIsIpv6": false,
"UtcTime": "2019-08-03 13:50:27.460",
"SrcASN": "Private",
"TgtASN": "FASTLY",
"TgtCountry": "United States",
"TgtCity": ""
}, |
Collaborator
Author
|
I also fixed #1724 :) {
"Timestamp": "2019-08-03 22:50:29.101 +09:00",
"RuleTitle": "Net Conn",
"Level": "info",
"Computer": "MSEDGEWIN10",
"Channel": "Sysmon",
"EventID": 3,
"RecordID": 5521,
"Details": {
"Initiated": true,
"Proto": "tcp",
"SrcIP": "10.0.2.15",
"SrcPort": 50105,
"SrcHost": "MSEDGEWIN10.home",
"TgtIP": "185.199.111.153",
"TgtPort": 443,
"TgtHost": "",
"User": "MSEDGEWIN10\\IEUser",
"Proc": "C:\\Windows\\System32\\mmc.exe",
"PID": 4372,
"PGUID": "747F3D96-9123-5D45-0000-001087596101",
"SrcASN": "Private",
"TgtASN": "FASTLY",
"TgtCountry": "United States",
"TgtCity": ""
},
"ExtraFieldInfo": {
"DestinationIsIpv6": false,
"DestinationPortName": "https",
"SourceIsIpv6": false,
"UtcTime": "2019-08-03 13:50:27.460"
},
"RuleID": "a87defd7-1f87-4a34-8864-415ccb2ef21c"
} |
YamatoSecurity
approved these changes
Dec 2, 2025
Collaborator
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket LGTM! Thanks so much for fixing both issues!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
-GeoIPis specified, the GeoIP fields are output in both theDetailsandExtraFieldInfoin json-timeline. #1724Evidence
Integraion-Test
I’d appreciate it if you could check it when you have time🙏