doc: remove outdated ARM architecture instructions from Timesketch doc#1728
Merged
YamatoSecurity merged 2 commits intomainfrom Dec 12, 2025
Merged
doc: remove outdated ARM architecture instructions from Timesketch doc#1728YamatoSecurity merged 2 commits intomainfrom
YamatoSecurity merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes outdated ARM architecture workaround instructions from Timesketch documentation, as the upstream Dockerfile now supports ARM architecture natively.
Key Changes:
- Removed ARM-specific Dockerfile modification instructions from both English and Japanese documentation
- Added a note in the Japanese documentation about Docker Desktop for Mac installation requirements (aligning with the English version)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/TimesketchImport/TimesketchImport-Japanese.md | Removed obsolete ARM architecture workaround steps and added Docker Desktop installation note for consistency |
| doc/TimesketchImport/TimesketchImport-English.md | Removed obsolete ARM architecture workaround steps from macOS installation section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
I also took the opportunity to fix the Clippy errors! |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YamatoSecurity
approved these changes
Dec 12, 2025
Collaborator
YamatoSecurity
left a comment
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket Thanks so much! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the following pull request made the Ubuntu 24.04 Docker image the default, rewriting the Dockerfile is no longer necessary. I updated the document!
Evience
Integration-Test
I’d appreciate it if you could check it when you have time🙏