fix: remove check for .git folder in YAML file processing#1729
Closed
fix: remove check for .git folder in YAML file processing#1729
Conversation
Collaborator
Author
After fix |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the check that ignores YAML files located within .git folders during YAML file processing, addressing issue #1727.
Key Changes
- Removed the
.gitfolder filtering logic from theread_dirmethod in theParseYamlimplementation
Comments suppressed due to low confidence (1)
src/yaml.rs:266
- The removal of the .git folder check creates an inconsistency in the codebase. The count_rules function at lines 664-669 still contains an identical check to ignore YAML files in .git folders. Both functions have similar purposes (processing YAML files recursively) and should handle .git folders consistently. Either both functions should skip .git folders, or neither should. Consider applying the same change to count_rules for consistency.
// ignore if tool test yml file in hayabusa-rules.
if utils::contains_str(path_str, "rules/tools/sigmac/test_files")
|| utils::contains_str(path_str, "rules\\tools\\sigmac\\test_files")
{
return io::Result::Ok(ret);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Evidence
Integration-Test
I’d appreciate it if you could check it when you have time🙏