fix: enhance hex to decimal conversion handling#1732
Merged
YamatoSecurity merged 4 commits intomainfrom Jan 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves HexToDecimal field conversion to be safer and more flexible when converting hex strings to decimal during field-data mapping.
Changes:
- Replaces fixed slicing (
[2..]) withstrip_prefix("0x"/"0X")to avoid panics on short strings. - Adds explicit handling for empty hex payloads after the prefix (e.g.,
"0x"), falling back to the original string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YamatoSecurity
approved these changes
Jan 30, 2026
Collaborator
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket I checked that it works well. Thanks so much!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Evidence
Integration-Test
I’d appreciate it if you could check it when you have time🙏