Skip to content

fix: enhance hex to decimal conversion handling#1732

Merged
YamatoSecurity merged 4 commits intomainfrom
fix-hexdecimal
Jan 30, 2026
Merged

fix: enhance hex to decimal conversion handling#1732
YamatoSecurity merged 4 commits intomainfrom
fix-hexdecimal

Conversation

@fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Jan 29, 2026

What Changed

  • Fixed array index access in hexadecimal conversion

Evidence

Integration-Test

I’d appreciate it if you could check it when you have time🙏

@fukusuket fukusuket requested a review from Copilot January 29, 2026 15:43
@fukusuket fukusuket added the bug Something isn't working label Jan 29, 2026
@fukusuket fukusuket self-assigned this Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves HexToDecimal field conversion to be safer and more flexible when converting hex strings to decimal during field-data mapping.

Changes:

  • Replaces fixed slicing ([2..]) with strip_prefix("0x"/"0X") to avoid panics on short strings.
  • Adds explicit handling for empty hex payloads after the prefix (e.g., "0x"), falling back to the original string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fukusuket fukusuket marked this pull request as ready for review January 29, 2026 15:46
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket I checked that it works well. Thanks so much!!

@YamatoSecurity YamatoSecurity merged commit 448a87c into main Jan 30, 2026
5 checks passed
@YamatoSecurity YamatoSecurity deleted the fix-hexdecimal branch January 30, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants