Redesign Personal Records: multi-record movement PRs + workout/benchmark PRs by Yanchek99 · Pull Request #1831 · Yanchek99/wod-tracker

Yanchek99 · 2026-07-29T02:39:15Z

Summary

Fixes two pre-existing bugs in the old "Personal Records" page: a 500 crash on movement logs without reps, and an ordering bug that showed whichever record was logged first instead of the best one.
A movement can now show multiple PRs at once instead of only the single highest-ranked one — e.g. Deadlift can show separate 1-rep-max, 5-rep-max, and 52-rep max-reps records, grouped/ranked per the rule table in the design doc.
Adds a new "Workout Records" page showing the user's best-ever score per workout (e.g. best Fran time, best Murph time).

Design: #1829
Plan: docs/superpowers/plans/2026-07-28-pr-view-redesign.md

Built with subagent-driven development: one implementer + one task-scoped reviewer per plan task, plus a final whole-branch review that caught and fixed one more bug (User#workout_records crashing on a log with no score_value).

Test plan

Full test suite green: 513 runs, 0 failures, 0 errors
RuboCop clean on all changed files
Each of the 5 implementation tasks individually reviewed (spec compliance + code quality)
Final whole-branch review completed, one Important finding fixed and re-verified

🤖 Generated with Claude Code

measurable_reps_msg crashed on movement logs with no reps recorded (load/distance/duration/calorie-only PRs). User#personal_records also showed whichever movement log was logged first, not the best one, because the inherited Log#movement_logs order(:id) scope silently won over the intended value-based ordering. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Design approved in #1829. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Excludes MovementRecordSet's rule-table dispatch method from the complexity/AbcSize cops (same pattern already used for Ability), since its branch count tracks the PR rule table rows, not incidental complexity.

… just one per movement

…ration Task 2 made User#personal_records return several MovementLog rows per movement (e.g. Deadlift at 1, 5, and 52 reps). The controller's sort only grouped by movement name, so multi-record rows for one movement appeared in insertion order instead of a readable progression.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

User#workout_records raised NoMethodError (time-scored nil) or ArgumentError (mixed nil/real scores) for any user with an unscored log, since score_value is nullable but only score_type is required. Guard nil so an unscored log always loses the comparison instead of crashing or winning by accident.

…_01WTLwi4FRhKYhikPnfneBCV

candidate_for was restructured into guard-clause methods along the rule table's own groupings (load / distance-or-duration / bare metric), so it satisfies AbcSize, CyclomaticComplexity, and PerceivedComplexity on its own merits instead of carving out per-file excludes in .rubocop.yml. The implementation plan now lives as a comment on the design issue (#1829 (comment)) rather than committed to the repo, matching how the design spec itself is tracked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

candidate_for was flagged for AbcSize/CyclomaticComplexity/PerceivedComplexity. Split into guard-clause methods along the rule table's own groupings (load / distance-or-duration / bare metric) instead of carving out per-file excludes in .rubocop.yml -- behavior and test coverage are unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

railway-app · 2026-07-29T02:56:05Z

🚅 Deployed to the pr-cf53cd-1831 environment in wod-tracker

Service	Status	Web	Updated (UTC)
web	😴 Sleeping (View Logs)	Web	Aug 21, 2026 at 9:45 pm
worker	✅ Success (View Logs)		Aug 21, 2026 at 9:38 pm

Every workout the user had ever logged was showing up as a "record," including one-off attempts and weight-scored lift workouts -- the latter are already represented on the movement PR page (grouped by rep count), so showing them again here was redundant. A workout now only appears once it's been logged more than once, and only if it isn't weight-scored. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Yanchek99

Thanks for the detailed PR description and test coverage. The movement record grouping PORO is nicely isolated, and the controller/view shape for the new page matches the existing user-scoped PR page. I found a few requirement mismatches against issue #1829 that should be fixed before merge: workout records currently exclude single-attempt workouts and weight-scored workouts even though the design says both qualify, the tests encode those exclusions, and movement PR display ordering does not match the duration-based grouping rule for fixed-duration records.

…ntroller Adds a Lifts / Repeated Workouts subnav under a single Personal Records section instead of two separate nav items.

…_01WTLwi4FRhKYhikPnfneBCV

Matches the existing .claude/.worktrees exclusions -- prevents skill-generated brainstorming/SDD scratch files from being committed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

The barbell action grouped weightlifting PRs without checking that load was present, so a reps-only record (no load) could render as a fabricated "0 lbs" PR and even outrank the real headline due to the reps-based sort. Filter the barbell tab to loaded records only, and guard rep_max_label so a loaded record with no rep count renders the load without a bare "RM" label instead of dropping the row.

…_01WTLwi4FRhKYhikPnfneBCV

Grew past the 100-line limit purely from merging two unrelated branches' independent test additions to this shared file -- not from any single change growing it. Matches the existing precedent for other oversized test files in this same cop.

Movements whose PRs are uniformly distance+time (no load) now match the Weightlifting tab's grouped/expand-in-place pattern: one row per movement, headlined by the most recently logged distance, expanding to show every distance in ascending order with its time. Reuses the existing generic rep-max-row Stimulus controller unchanged. Records that aren't distance+time shaped (calorie-based tests, reps-in-a-time-cap tests) stay in the existing flat list below the grouped movements -- nothing disappears, nothing gets forced into a row format that doesn't fit its shape.

distance_label now renders "500m" instead of "500 meters". duration_msg reuses MeasurableHelper's existing duration_metric_msg, which already drops the leading "00:" when there are no hours (e.g. "20:00" instead of "00:20:00") -- an established format elsewhere in the app, not a new one.

Yanchek99 · 2026-08-12T20:55:03Z

Blocked by #1860 — the Weightlifting tab's rep-max ("NRM") grouping in this PR labels any weightlifting record with reps+load present, without verifying the reps were performed as one continuous, unbroken set (e.g. an interval-ladder total like Diane's 45-rep aggregated deadlift entry would render as "45RM"). #1860 tracks adding that verification. This PR can merge as-is, but #1860 should land soon after to avoid shipping misleading rep-max claims.

…_01WTLwi4FRhKYhikPnfneBCV # Conflicts: # app/helpers/measurable_helper.rb # app/javascript/controllers/index.js # test/helpers/measurable_helper_test.rb

Resolves #1860: a rep count > 1 (e.g. Diane's aggregated 45-rep Deadlift, Murph's 100 pull-ups) is only shown as a rep-max PR once MovementLog#set_breakdown verifies a genuine unbroken effort, via the new MovementLog#verified_unbroken_reps. The Weightlifting tab labels off the verified count instead of the raw total, and the same exclusion now applies to the Gymnastics flat list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Yanchek99 · 2026-08-17T22:31:48Z

#1860 is resolved (merged as #1861, plus follow-up work on this branch to actually wire the Weightlifting and Gymnastics tabs into it). No longer blocked.

A rep count > 1 (e.g. Diane's aggregated 45-rep Deadlift, Murph's 100 pull-ups) is now only shown as a rep-max PR once MovementLog#set_breakdown verifies a genuine unbroken effort — otherwise it's excluded rather than rendering a fabricated claim. The Weightlifting tab labels off the verified count (e.g. Diane's Deadlift now correctly reads "21RM", not "45RM"), and the same gate applies to the Gymnastics flat list, since a gymnastics rep count carries the same implicit "max unbroken reps" claim.

single_weightlifting_exercise_day? only recognized a workout with exactly one exercise total, missing the far more common variable set-based lifting structure (e.g. "Back Squat: 5-5-3-3-1-1", multiple sets of the same movement, scored by weight). Reuse the existing Workout#set_based_lifting? concept, which already covers both the fixed-round and variable-set shapes, instead of the narrower ad-hoc check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

A single recorded set (e.g. one line of a "5x5 Back Squat", set_breakdown: [5]) isn't a "breakdown" -- there's nothing split across multiple sets to reveal, so showing "[5]" next to "5 Back Squats" was just noise. The verification data itself (needed for the Weightlifting rep-max gate) is unchanged; only the display is suppressed when there's one set to show. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…_01WTLwi4FRhKYhikPnfneBCV

…ubmission Verifies the full LogsController#create path -- not just Log#build_movement_logs -- correctly auto-populates set_breakdown for a set-based lifting day even when the recording form's hidden set_breakdown_text field submits blank. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

MovementLog#verified_unbroken_reps required a captured set_breakdown for any reps > 1, which meant historical set-based lifting logs (e.g. old "5x5 Back Squat" entries) stayed excluded from the Weightlifting tab even though set_based_lifting? already proves them unbroken by construction. That proof comes from workout structure (segments, exercises, score type) that already exists for every log, old or new -- trust reps directly in that case instead of requiring set_breakdown to have been written first. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…turally too verified_unbroken_reps only recognized set_based_lifting? (weighted sets), so a bare "how many can you do" bodyweight test -- one exercise, prescribed reps: 0, no time cap -- still required a captured set_breakdown despite being unbroken by definition: going until failure in one continuous attempt is what the test is. Reuse the existing Workout#single_achievement_test? concept, which already identifies exactly this shape, regardless of movement family. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…_01WTLwi4FRhKYhikPnfneBCV # Conflicts: # app/models/concerns/log_set_breakdown.rb

Yanchek99 and others added 8 commits July 28, 2026 16:16

Add implementation plan for PR view redesign

25ea71a

Design approved in #1829. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Add MovementRecordSet to rank/group movement logs into distinct PRs

2962826

Excludes MovementRecordSet's rule-table dispatch method from the complexity/AbcSize cops (same pattern already used for Ability), since its branch count tracks the PR rule table rows, not incidental complexity.

Show one personal record per distinct rep/distance/duration test, not…

7ff94c8

… just one per movement

Add User#workout_records for best-score-per-workout tracking

3f6f9d7

Add Workout Records page showing best score per workout

e6adcb5

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 July 29, 2026 02:39 Destroyed

Merge remote-tracking branch 'origin/master' into worktree-bridge-cse…

5c2dd36

…_01WTLwi4FRhKYhikPnfneBCV

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 July 29, 2026 02:47 Destroyed

Yanchek99 and others added 2 commits July 28, 2026 19:50

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 July 29, 2026 02:52 Destroyed

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 July 29, 2026 04:00 Destroyed

Yanchek99 commented Jul 29, 2026

View reviewed changes

Comment thread app/models/user.rb

Comment thread app/models/user.rb

Comment thread test/models/user_test.rb

Comment thread test/models/user_test.rb

Comment thread app/controllers/movement_logs_controller.rb Outdated

Yanchek99 added 2 commits August 4, 2026 15:08

Merge Personal Records and Workout Records into one PersonalRecordsCo…

425dd10

…ntroller Adds a Lifts / Repeated Workouts subnav under a single Personal Records section instead of two separate nav items.

Merge remote-tracking branch 'origin/master' into worktree-bridge-cse…

360cd54

…_01WTLwi4FRhKYhikPnfneBCV

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 August 4, 2026 22:10 Destroyed

Yanchek99 mentioned this pull request Aug 5, 2026

Redesign Personal Records: multi-record movement PRs + workout/benchmark PRs #1829

Open

Yanchek99 and others added 4 commits August 5, 2026 08:32

Ignore .superpowers/ agent scratch workspace

67af9ce

Matches the existing .claude/.worktrees exclusions -- prevents skill-generated brainstorming/SDD scratch files from being committed.

Add Barbell Lifts tab grouping rep-maxes by movement

22f452d

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Wire up expand/collapse for Barbell Lifts rows

253a1ed

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 August 5, 2026 16:35 Destroyed

Merge remote-tracking branch 'origin/master' into worktree-bridge-cse…

063d1a6

…_01WTLwi4FRhKYhikPnfneBCV

railway-app Bot deployed to wod-tracker / wod-tracker-pr-1831 August 5, 2026 18:03 View deployment

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 August 6, 2026 20:44 Destroyed

railway-app Bot temporarily deployed to wod-tracker / wod-tracker-pr-1831 August 6, 2026 21:01 Destroyed

Yanchek99 closed this Aug 6, 2026

Yanchek99 reopened this Aug 6, 2026

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 6, 2026 21:45 Destroyed

Merge branch 'master' into worktree-bridge-cse_01WTLwi4FRhKYhikPnfneBCV

1af4f40

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 11, 2026 20:53 Destroyed

Yanchek99 mentioned this pull request Aug 12, 2026

Capture verified set breakdown on MovementLog as athlete-performance training signal #1860

Closed

34 tasks

Yanchek99 and others added 2 commits August 17, 2026 14:57

Merge remote-tracking branch 'origin/master' into worktree-bridge-cse…

91b1370

…_01WTLwi4FRhKYhikPnfneBCV # Conflicts: # app/helpers/measurable_helper.rb # app/javascript/controllers/index.js # test/helpers/measurable_helper_test.rb

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 17, 2026 22:31 Destroyed

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 18, 2026 04:22 Destroyed

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 19, 2026 03:37 Destroyed

Yanchek99 and others added 2 commits August 19, 2026 08:36

Merge remote-tracking branch 'origin/master' into worktree-bridge-cse…

fea4040

…_01WTLwi4FRhKYhikPnfneBCV

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 19, 2026 15:36 Destroyed

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 19, 2026 18:11 Destroyed

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 19, 2026 18:19 Destroyed

Merge remote-tracking branch 'origin/master' into worktree-bridge-cse…

126ad85

…_01WTLwi4FRhKYhikPnfneBCV # Conflicts: # app/models/concerns/log_set_breakdown.rb

railway-app Bot temporarily deployed to wod-tracker / pr-cf53cd-1831 August 21, 2026 21:36 Destroyed

Yanchek99 merged commit 836fffb into master Aug 21, 2026
8 checks passed

Yanchek99 deleted the worktree-bridge-cse_01WTLwi4FRhKYhikPnfneBCV branch August 21, 2026 21:59

Navigation Menu

Redesign Personal Records: multi-record movement PRs + workout/benchmark PRs - #1831

Redesign Personal Records: multi-record movement PRs + workout/benchmark PRs#1831
Yanchek99 merged 42 commits into
masterfrom
worktree-bridge-cse_01WTLwi4FRhKYhikPnfneBCV

Yanchek99 commented Jul 29, 2026

Uh oh!

railway-app Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

Yanchek99 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yanchek99 commented Aug 12, 2026

Uh oh!

Yanchek99 commented Aug 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Yanchek99 commented Jul 29, 2026

Summary

Test plan

Uh oh!

railway-app Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yanchek99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yanchek99 commented Aug 12, 2026

Uh oh!

Yanchek99 commented Aug 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

railway-app Bot commented Jul 29, 2026 •

edited

Loading