Show load input by default on set-based lifting workouts - #1870
Merged
Conversation
Movement cards hid the Load field whenever the exercise had no fixed load prescribed (e.g. Deadlift 5-3-3-2-1-1-1, where the athlete picks their own weight per set). For calculated-lifting-score workouts the load is exactly what determines the score, so it should be visible without requiring an extra "Edit" click. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🚅 Deployed to the wod-tracker-pr-1870 environment in wod-tracker
|
railway-app
Bot
temporarily deployed
to
wod-tracker / wod-tracker-pr-1870
August 19, 2026 15:47
Destroyed
…fting day single_weightlifting_exercise_day? only recognized the fixed-rounds set-based lifting structure (one exercise row x N rounds, e.g. Back Squat 5x5). A variable-rep-scheme lift like Deadlift 5-3-3-2-1-1-1 is stored as separate exercise rows per set, so the check missed it, set_breakdown never got auto-populated, and the log form showed a "Set breakdown" field for what is already a single discrete set. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
wod-tracker / wod-tracker-pr-1870
August 19, 2026 17:08
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculated_lifting_score?, the load is the score input, so it now shows by default instead of requiring a click on "Edit" for every card.Test plan
test/system/log_recording_form_test.rb(5 tests, all pass)test/models/log_test.rb,test/models/workout_test.rb,test/controllers/logs_controller_test.rb(99 tests, all pass)🤖 Generated with Claude Code