Fix i18n: invalid default, English fallback, absolute config path#455
Open
minh-vt wants to merge 4 commits into
Open
Fix i18n: invalid default, English fallback, absolute config path#455minh-vt wants to merge 4 commits into
minh-vt wants to merge 4 commits into
Conversation
04d67be to
9019e22
Compare
… to clamp to zero-area corner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app has a complete i18n system (8 languages, full
en.ini), but three bugs make it fragile:P0 — Fresh install crash:
Config.interfacedefaulted to"ChineseSimplified", which isn't in the validator's option set['ch', 'chinese_cht', 'en', ...]. On first launch with noconfig.json,ComboBoxSettingCardthrowsKeyError.P1 — Missing translation keys crash non-English users: Every UI string uses
tr['Section']['Key']— direct dict access. If any non-English.iniis missing a key, it's an unhandledKeyErrorfor all users of that language.P2 — Config path is CWD-dependent:
qconfig.load('config/config.json', config)resolves relative to the current working directory. Run from anywhere except the project root and settings silently fail to load.Changes in
backend/config.pyinterface = OptionsConfigItem(..., "ChineseSimplified", ...)interface = OptionsConfigItem(..., "ch", ...)tr.read(f"{user}.ini")— single fileen.inias base, overlay user languageCONFIG_FILE = "config/config.json"os.path.abspath(__file__)f"en.ini""en.ini"Files changed: 1