Fix late line complete callback in line with markup #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes YarnSpinnerTool#328 When showing characters with the typewriter effect the `LinePresenter` loops the characters in the string and sets maxVisibleCharacters on the Textmesh component. If a line has markup tags those will be looped too. That means when a line contains markup it will exceed the number of characters that needs to be passed to TM causing a delay between the text becoming visible at runtime and the `OnLineDisplayComplete()` method being called. This can cause issues if, for example, a connected `ActionMarkupHandler` needs to decide whether call `RequestHurryUpLine()` or `RequestNextLine()` as the line will be visibly finished, but the loop will still be running for the count of extra characters. This replaces the total count in the loop with the amount of visible characters so it will sync back up. For some reason `lineText.textInfo` doesn't contain the correct current count but calling `lineText.GetTextInfo()` with the current line text does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
When showing characters with the typewriter effect the
LinePresenterloops the characters in the string and sets maxVisibleCharacters on the Textmesh component. If a line has markup tags those will be looped too. That means when a line contains markup it will exceed the number of characters that needs to be passed to TM causing a delay between the text becoming visible at runtime and theOnLineDisplayComplete()method being called.This can cause issues if, for example, a connected
ActionMarkupHandlerneeds to decide whether callRequestHurryUpLine()orRequestNextLine()as the line will be visibly finished, but the loop will still be running for the count of extra characters.This replaces the total count in the loop with the amount of visible characters so it will sync back up.
For some reason
lineText.textInfodoesn't contain the correct current count but callinglineText.GetTextInfo()with the current line text does.