fix: align persistent stop hook and tighten agent output contracts#2653
fix: align persistent stop hook and tighten agent output contracts#2653Yeachan-Heo merged 1 commit intodevfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89eb0de5ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "type": "command", | ||
| "command": "node \"$CLAUDE_PLUGIN_ROOT\"/scripts/run.cjs \"$CLAUDE_PLUGIN_ROOT\"/scripts/persistent-mode.cjs", | ||
| "command": "node \"$CLAUDE_PLUGIN_ROOT\"/scripts/run.cjs \"$CLAUDE_PLUGIN_ROOT\"/scripts/persistent-mode.mjs", |
There was a problem hiding this comment.
Keep Stop hook on feature-parity implementation
Changing the Stop hook target to scripts/persistent-mode.mjs removes continuation safeguards for active Skill-tool workflows, because that script currently lacks the skill-active-state.json blocking path that exists in scripts/persistent-mode.cjs (the cjs implementation still enforces reinforcements before allowing stop). In sessions where skills like plan, code-review, or tdd are mid-flight, Stop can now pass through early and terminate the run before the skill finishes.
Useful? React with 👍 / 👎.
Summary
persistent-mode.mjspathTesting