Skip to content

Prevent live session pointers from native-start replacement#3235

Merged
Yeachan-Heo merged 1 commit into
Yeachan-Heo:devfrom
WangErgouaaaa:fix/native-session-no-live-replace
Jul 20, 2026
Merged

Prevent live session pointers from native-start replacement#3235
Yeachan-Heo merged 1 commit into
Yeachan-Heo:devfrom
WangErgouaaaa:fix/native-session-no-live-replace

Conversation

@WangErgouaaaa

Copy link
Copy Markdown

Summary

  • Reject native SessionStart reconciliation when a live pointer already belongs to a different native session.
  • Preserve same-native metadata refresh and stale/dead pointer recovery behavior.
  • Update session and native-hook regressions, including PATH isolation for conductor direct-write tests.

Why

A nested or ephemeral native Codex session could publish over a live parent pointer. Stop authorization then sees stale or unrelated pointer evidence and fails closed.

Test Plan

  • npm run build
  • npm run check:no-unused
  • node dist/scripts/run-test-files.js dist/hooks/__tests__/session.test.js
  • node dist/scripts/run-test-files.js dist/scripts/__tests__/codex-native-hook.test.js
  • git diff --check

Not Tested

  • Installed OMX live smoke after packaging.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@Yeachan-Heo
Yeachan-Heo changed the base branch from main to dev July 20, 2026 06:05
@Yeachan-Heo
Yeachan-Heo force-pushed the fix/native-session-no-live-replace branch from f44babf to a049486 Compare July 20, 2026 07:12

@Yeachan-Heo Yeachan-Heo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh review of a049486: live native SessionStart replacement now fails closed with session_pointer_owner_conflict and preserves the existing pointer. Verified npm run build, npm run check:no-unused, session-pointer suite (69/69), and native-hook suite (571/571).


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Yeachan-Heo merged commit 5fcec36 into Yeachan-Heo:dev Jul 20, 2026
20 checks passed
@Yeachan-Heo

Yeachan-Heo commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Terminal verification: squash-merged to dev as 5fcec36. Hosted CI run 29723911262 completed successfully with required CI Status green; the fresh approval reviewed a049486. No linked closing issue or open backlog reference was found.

Reviewed-by: Yeachan-Heo


[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants