build(deps-dev): bump c8 from 11.0.0 to 12.0.0#3250
Conversation
dependabot
Bot
added
dependencies
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Yeachan-Heo
left a comment
Yeachan-Heo
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES
PR #3250 changes the documented contributor tooling contract without updating it. CONTRIBUTING.md and package.json declare Node >=20, but c8 12.0.0 (via yargs 18) declares ^20.19.0 || ^22.12.0 || >=23. Canonical npm ci --ignore-scripts --engine-strict confirms the head rejects Node 20.18.1 and 22.11.0; the base accepts both. Node 21 is a separate pre-existing dependency-policy gap, not newly introduced by this PR.
The dependency/lock delta is otherwise confined to package.json and package-lock.json, is dev-only and attributable to c8/yargs 18 display-stack transitives. The exact head's required CI Status is freshly successful and the PR is clean/rebaseable, but floating Node-20/22 CI does not prove the documented lower bounds. The c8 team coverage gate produced the expected JSON/lcov schema and cleared thresholds (lines/statements 87.09%, functions 94.78%, branches 80.55%); the full local c8 run remains in progress and is not relied on for this decision.
Resolve the contract before merging: either retain c8 11, or explicitly define and document the contributor/tooling range as ^20.19.0 || ^22.12.0 || >=23 while separately preserving any broader consumer runtime policy. >=20.19 is not equivalent because it admits unsupported Node 21 and Node 22.0–22.11.
—
[repo owner's gaebal-gajae (clawdbot) 🦞]
44d94d9 to
e07d483
Compare
Bumps [c8](https://github.com/bcoe/c8) from 11.0.0 to 12.0.0. - [Release notes](https://github.com/bcoe/c8/releases) - [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md) - [Commits](bcoe/c8@v11.0.0...v12.0.0) --- updated-dependencies: - dependency-name: c8 dependency-version: 12.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8a81ef4 to
ade2342
Compare
Yeachan-Heo
left a comment
Yeachan-Heo
left a comment
There was a problem hiding this comment.
GJC exact-head approval for ade2342.
Receipt:
- Rebased onto dev 300f3f8 with force-with-lease.
- Fresh hosted CI 29810393834 is terminal success on this exact head.
- Fresh independent adversarial verdict: MERGE_READY; base/head diff is only non-semantic relocation of existing Biome libc selectors, with c8 11.0.0 and engine 20 || >=22 preserved.
- No Node policy, docs, CI matrix, dependency version, integrity, or merged-dev dependency update was changed.
|
Audit correction for approval review #4742308032. Exact approved head: The approval remains substantively unchanged. This correction supplies the missing owner attribution footer. Owner attribution: Yeachan-Heo (repository owner) |
|
Final audit correction for approval review #4742308032 and correction comment #5031360450. Exact approved head: The substantive approval remains unchanged; this comment supplies the mandatory signature footer. — |
|
GJC final receipt.
— |
1 participant
Bumps c8 from 11.0.0 to 12.0.0.
Release notes
Sourced from c8's releases.
Changelog
Sourced from c8's changelog.
Commits
ae5a0cfchore(main): release 12.0.0 (#600)dc2d6c8feat!: update yargs to 18.x.x (#599)ee2f1cfchore(deps): update dependency@types/nodeto v24 (#579)923c238build: go back to publishing manually