Add option for Microsoft Webview dependency#265
Open
Mino5531 wants to merge 2 commits into
Open
Conversation
|
Can be great to add this feature ! |
|
@YehudaKremer, could you take a look at this, or maybe even a general approach to add dependencies? |
Author
|
Hi, just wanted to add, that I don't recommend using the dependency feature of MSIX files. The dependency installations fails pretty often and the error messages can be very confusing for users. Integrating the installation process of the Webview dependency into the flutter app directly is pretty straightforward so I would recommend doing that instead of relying on the MSIX dependency installation. |
|
Thank you for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an option for adding the Microsoft Webview dependency to the generated msix file.
The Microsoft Webview dependency is required when using packages such as: desktop_webview_window