Add Shorebird build tool support for Windows packaging#315
Open
kingdomseed wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive support for using Shorebird as an alternative build tool for Windows app packaging in the MSIX plugin, addressing both issue #314 in msix and issue #3201 in shorebird.
Issues Addressed
Changes Made
Core Configuration
windows_build_toolconfiguration option (defaults toflutter, supportsshorebird)shorebird_argsconfiguration for passing arguments toshorebird release windows--windows-build-tooland--shorebird-argsBuild System Updates
WindowsBuildclass to support multiple build tools_buildWithShorebird()method that executesshorebird release windows_getShorebirdPath()function with smart path resolution (respectsSHOREBIRD_BINenvironment variable)Documentation
Code Quality
void,bool) where missingUsage Examples
YAML Configuration
CLI Usage
Testing
windows_build_toolconfiguration parsing and validationshorebird_argsparsing from both YAML and CLIflutterorshorebirdare accepted as build toolsBackward Compatibility
This change is fully backward compatible. Existing projects will continue to use Flutter as the default build tool unless explicitly configured otherwise.
How This Solves the Issues
For msix#314: Provides a seamless way for users to opt into Shorebird's Windows build pipeline while maintaining all existing MSIX packaging functionality.
For shorebird#3201: Enables Shorebird users to package their Windows apps as MSIX without manual workarounds, supporting the full
shorebird release windowsworkflow with custom arguments.