feat: Clarify the semantics of src_key and dst_key - #218
Open
HalfSweet wants to merge 4 commits into
Open
Conversation
Yikun
reviewed
Jan 23, 2026
Yikun
reviewed
Jan 23, 2026
| self.repo_path, | ||
| kill_after_timeout=self.timeout, | ||
| ) | ||
| if self._uses_ssh_for_src(): |
Owner
There was a problem hiding this comment.
Please add note here to show branch case
| with: | ||
| src: github/kunpengcompute | ||
| dst: gitee/kunpengcompute | ||
| src_key: ${{ secrets.GITHUB_PRIVATE_KEY }} |
Owner
There was a problem hiding this comment.
I suggested donot add this and add a new case for separate src_key and dst_key consider src_key is not a required parameter.
Keep simple will reduce new users onboard.
HalfSweet
force-pushed
the
refactor_key
branch
from
February 3, 2026 15:50
fc790e9 to
d4b1eab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.