fix(Clang&MinGW): Fix Clang and MinGW builds on linux. #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may break building with clang for windows-gnu target, but it probably doesn't work anyway.
|
Download the artifacts for this pull request: |
| @@ -28,6 +28,7 @@ namespace rage | |||
| std::uint32_t m_CxnId; // 0x0044 | |||
| rage::netEvent* m_This; // 0x0048 | |||
| uint32_t m_PeerId; // 0x0050 | |||
| char pad_0084[4]; // 0x0054 | |||
There was a problem hiding this comment.
Wonder why GCC wants padding here. Might be a compiler bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This likely breaks building with clang for windows-gnu target, but it probably doesn't work anyway.
Updates
minhookandnlohmann::jsonto work on latest cmake.Adds clangd's
.cachedirectory to.gitignore.This was not tested in game!Should work in game.