feat(agilepool): add Prometheus monitoring and task duration sampling support#69
Open
Bury-Lee wants to merge 9 commits into
Open
feat(agilepool): add Prometheus monitoring and task duration sampling support#69Bury-Lee wants to merge 9 commits into
Bury-Lee wants to merge 9 commits into
Conversation
Bury-Lee
commented
Jun 27, 2026
Bury-Lee
commented
Contributor
- Add built-in Prometheus monitoring metrics, including pool runtime status and latency statistics for each stage of task execution
- Add WithSampleRate configuration option and SetSampleRate method to support adjusting the monitoring reporting ratio
- Implement automatic timestamp propagation via task Context, enabling automatic collection of duration data at each stage
- Add Taker, a tool for periodically collecting pool status, along with custom collection callbacks
- Add comprehensive test cases related to monitoring
- Update the example program to demonstrate the usage workflow for Prometheus integration
- Add Prometheus client dependency to go.mod and go.sum
… support - Add built-in Prometheus monitoring metrics, including pool runtime status and latency statistics for each stage of task execution - Add WithSampleRate configuration option and SetSampleRate method to support adjusting the monitoring reporting ratio - Implement automatic timestamp propagation via task Context, enabling automatic collection of duration data at each stage - Add Taker, a tool for periodically collecting pool status, along with custom collection callbacks - Add comprehensive test cases related to monitoring - Update the example program to demonstrate the usage workflow for Prometheus integration - Add Prometheus client dependency to go.mod and go.sum
…n of ct.ctx Previously, worker.runTask directly modified ct.ctx field, causing concurrent read/write races with pool.submit(). Now we create a new sendCtx chain and never mutate ct.ctx, ensuring thread-safe context propagation while preserving all timing values (SubmittedAt, EnqueuedAt, StartedAt, CompletedAt).
…fo field Use a separate countInfo field as the statistics context instead of reusing the passed-in ctx. This field is program-modifiable only and is updated multiple times during task execution, but read exactly once for metric collection before being discarded.
- Change `contextTask.countInfo` from bare `context.Context` to `*countInfo` struct with embedded `sync.Mutex` for thread-safe access - Add nil-guard before locking in `submit()` to prevent panic when `contextTask` comes from `SubmitCtx` (countInfo not pre-initialised) - Guard submit-time context stamping with `countInfo.mu.Lock/Unlock` - Fix three `ct.countInfo = ctx` type mismatches → `ct.countInfo.Context = ctx` (NONBLOCK path, blocking fast path, and initial submit block) - Update `worker.runTask` to use `ct.countInfo.Context` explicitly instead of relying on the promoted interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.