[ENH](/[REFAC]) Docker Image Building and Usage refactor.

[DaanSelen]

Please ask your questions here.

[DaanSelen]

Its a lot of changes so please do ask your questions. I will explain ASAP!

[DaanSelen]

@jacobalberty Please try and build again with new code.

[jacobalberty]

@DaanSelen so far everything looks like its working fine

[DaanSelen]

@DaanSelen so far everything looks like its working fine

Sounds good, I do want to thank you for the time you spent testing it! I hope it will make master one day.

[DaanSelen]

I can still confirm that with the latest MeshCentral version I can build my own images with my prefered backend (postgresql) and update the docker way flawlessly.

[DaanSelen]

Any more information needed?

[si458]

@DaanSelen sorry for the delay in this, a gent has just emailed me an intresting report for the latest docker image
attached is a vulnerability scan for latest image output.txt (publicly available using trivy)

BUT ive just discovered a few package issues which im going to fix

BUT html-minifier jsdom esprima are ONLY required for translations,
they are installed, translations happen, then the node_modules folder is deleted,
but they arent actually removed from the package.json!

so when it runs npm install next time round, it reinstalls them and it should not do this!

shouldnt we just npm uninstall the packages in the cleanup section?

EDIT: ive done a fix here for our normal docker image - 4fc921c so you might need to fix your PR

[DaanSelen]

@DaanSelen sorry for the delay in this, a gent has just emailed me an intresting report for the latest docker image attached is a vulnerability scan for latest image output.txt (publicly available using trivy)

BUT ive just discovered a few package issues which im going to fix

BUT html-minifier jsdom esprima are ONLY required for translations, they are installed, translations happen, then the node_modules folder is deleted, but they arent actually removed from the package.json!

so when it runs npm install next time round, it reinstalls them and it should not do this!

shouldnt we just npm uninstall the packages in the cleanup section?

EDIT: ive done a fix here for our normal docker image - 4fc921c so you might need to fix your PR

I will look at your commit and inplement this into the REFACTOR.

[DaanSelen]

@si458 I changed some things please review!

[si458]

@DaanSelen i still cant merge im afraid as the is a conflict in Dockerfile https://github.com/Ylianst/MeshCentral/pull/6937/conflicts

[DaanSelen]

Bimpy bumpy

[si458]

can u just resolve the conflict plz and ill merge and make changes!

[DaanSelen]

Yay!