[ENH] bootstrap themes across light and dark mode#6950
Conversation
|
this sadly hasnt really worked, |
Oops, I tested with a MeshCentral instance without any device group(no devices data at all), which is why I couldn't see that part. I was only referring to the page titles to see if everything works. I will continue the work and push changes. |
Thank you for your time and effort in advance! |
|
@Ndaboom sorry thats made it worse! and i was just using the default color theme in day mode |
|
@Ndaboom is this still going on? |
Yes, it is, but I haven't had a chance to continue working yet. I will follow up here very soon when I get something. |
…headings, text, forms, and navigation elements
Ndaboom
force-pushed
the
fix-boostrap_ensures_title_consistency
branch
from
ad2d55c to
7157422
Compare
…emes, ensuring better visibility and contrast for text and buttons
…oth light and dark modes with appropriate styles
…s in span tags for better styling and visibility
…for improved consistency
…ext, and spans for improved visibility
Ndaboom
changed the title
|
Hi @si458, I've made a few changes. Could you test them when you have a chance? Thank you. |
…with improved specificity
Ndaboom
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump? |
|
@Ndaboom What is the next step? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@si458 what is halting it? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Any steps: @si458 ? |
|
@Ndaboom can u fix conflict please, then can re-look at this 👍 |
|
@si458 @DaanSelen Are we good to merge? |
For me this is OK! Simon has to give the green light. |
si458
left a comment
si458
left a comment
There was a problem hiding this comment.
please make changes to fix translation issues
| } else { | ||
| r += '</table>'; | ||
| if (sort == 3) { r = '<div style="margin:10px"><i>' + "No devices with tags found." + '</i></div>'; } | ||
| if (sort == 3) { r = '<div style="margin:10px"><i>' + "<span>No devices with tags found</span>." + '</i></div>'; } |
There was a problem hiding this comment.
please can you move the and so its outside the " "
example <i><span>' + "abc" + '</span></i>
this makes sure the string in the middle isnt changed for translations
| } else if (mesh.mtype == 4) { | ||
| r += '<td><div id=DevxCol' + deviceHeaderId2 + ((collapsed === true) ? ' style=display:none' : '') + '>'; // Open collapse div | ||
| r += '<div style=padding:10px><i>' + "No devices in this device group"; | ||
| r += '<div style=padding:10px><i>' + "<span>No devices in this device group</span>"; |
There was a problem hiding this comment.
please can you move the and so its outside the " "
example <i><span>' + "abc" + '</span></i>
this makes sure the string in the middle isnt changed for translations
| } else if (mesh.mtype == 3) { | ||
| r += '<td><div id=DevxCol' + deviceHeaderId2 + ((collapsed === true) ? ' style=display:none' : '') + '>'; // Open collapse div | ||
| r += '<div style=padding:10px><i>' + "No local devices in this device group"; | ||
| r += '<div style=padding:10px><i>' + "<span>No local devices in this device group</span>"; |
There was a problem hiding this comment.
please can you move the and so its outside the " "
example <i><span>' + "abc" + '</span></i>
this makes sure the string in the middle isnt changed for translations
| } else if (mesh.mtype == 2) { | ||
| r += '<td><div id=DevxCol' + deviceHeaderId2 + ((collapsed === true) ? ' style=display:none' : '') + '>'; // Open collapse div | ||
| r += '<div style=padding:10px><i>' + "No devices in this device group"; | ||
| r += '<div style=padding:10px><i>' + "<span>No devices in this device group</span>"; |
There was a problem hiding this comment.
please can you move the and so its outside the " "
example <i><span>' + "abc" + '</span></i>
this makes sure the string in the middle isnt changed for translations
| r += '</span></td></tr><tr>'; | ||
| if (mesh.mtype == 1) { | ||
| r += '<td><div style=padding:10px><i>' + "No Intel® AMT devices in this device group"; | ||
| r += '<td><div style=padding:10px><i>' + "<span>No Intel® AMT devices in this device group</span>"; |
There was a problem hiding this comment.
please can you move the and so its outside the " "
example <i><span>' + "abc" + '</span></i>
this makes sure the string in the middle isnt changed for translations
4 participants
This fix sets explicit text colors for
<h1>elements in both light and dark modes to ensure visibility and maintain visual contrast. A very dark gray (#adafae) is used for light mode to avoid pure black on white, improving readability and aesthetics, while a very light gray (#f8f9fa) is used in dark mode for optimal contrast.