feat: set modern UI as default and add option to switch to classic

[DaanSelen]

No description provided.

[panreyes]

I haven't tested it, and some of the commits include code cleanups and changes related to other features, but the code looks good to me.

[DaanSelen]

I haven't tested it, and some of the commits include code cleanups and changes related to other features, but the code looks good to me.

Thanks for the review! Its always welcome

[aelfwine88]

Does modern UI work proprly on mobile devices already? Last time I checked it had serious issues.

[DaanSelen]

Does modern UI work proprly on mobile devices already? Last time I checked it had serious issues.

I believe so, but otherwise CLASSIC can be forced.

[aelfwine88]

@DaanSelen : I just tested it and remote control is still absolutely broken and unusable with modern UI on mobile devices (in mobile view).

So essentially you want to make another UI default that is...
Pros: looks different
Cons: breaks a major functionality on all mobile devices

I would suggest: before making it default someone from the development/testing team actually test all of the functionalities (and fix the broken ones) on the 2 supported views you have: desktop and mobile.

[panreyes]

What is currently broken in modern UI?
I've just tested Desktop and I only missed the lower right tools and the full screen button.

Aside from that, it works just fine for me.

(But it might also be related to me having less elements in my UI, I removed some to make it more simple)

[DaanSelen]

@DaanSelen : I just tested it and remote control is still absolutely broken and unusable with modern UI on mobile devices (in mobile view).

So essentially you want to make another UI default that is... Pros: looks different Cons: breaks a major functionality on all mobile devices

I would suggest: before making it default someone from the development/testing team actually test all of the functionalities (and fix the broken ones) on the 2 supported views you have: desktop and mobile.

I have never considered mobile remote connect to be such an important part. Besides that: have you made Github issues for the points you are referencing?

[aelfwine88]

What is currently broken in modern UI? I've just tested Desktop and I only missed the lower right tools and the full screen button.

Aside from that, it works just fine for me.

(But it might also be related to me having less elements in my UI, I removed some to make it more simple)

How is "it loads the desktop" a functional test?

Yes it loads the desktop but how anyone suppose to control a full screen desktop on a phone screen without the "Full Screen" function of the Classic UI..?
On your tiny screen of your screenshot, how do start a program, enter any text into the desktop or use it functionally any ways?

@DaanSelen : I just tested it and remote control is still absolutely broken and unusable with modern UI on mobile devices (in mobile view).
So essentially you want to make another UI default that is... Pros: looks different Cons: breaks a major functionality on all mobile devices
I would suggest: before making it default someone from the development/testing team actually test all of the functionalities (and fix the broken ones) on the 2 supported views you have: desktop and mobile.

I have never considered mobile remote connect to be such an important part. Besides that: have you made Github issues for the points you are referencing?

Well it is there since I guess there was a demand for it which is understandable since all major remote management software has mobile support (android/ios). In our society people use their mobile devices more than their computers for sure. If MeshCentral's mobile desktop control feature would be better it would be the perfect selfhosted alternative for any remote management tool currently on the market.

Also I still not really understand the logic of breaking major functionality for a sake of a new skin.

If you referring the point of "remote control is not usable on the mobile version of modern UI" then no, I only posted it on the discord channel several months back. But tbh I would still expect that a development cycle of this software contains actual functional testing of the major functions of the software before a major change like a new UI is getting pushed out.

[panreyes]

How is "it loads the desktop" a functional test?

Why do you say that the modern UI doesn't work correctly? We still don't know.

[DaanSelen]

Also I still not really understand the logic of breaking major functionality for a sake of a new skin.

If you referring the point of "remote control is not usable on the mobile version of modern UI" then no, I only posted it on the discord channel several months back. But tbh I would still expect that a development cycle of this software contains actual functional testing of the major functions of the software before a major change like a new UI is getting pushed out.

We can always set the default to the classic UI and have people that want the new skin to opt-in.
But we have to make the switch one day, and the more reports/users we have, the faster we can debug.

[aelfwine88]

How is "it loads the desktop" a functional test?

Why do you say that the modern UI doesn't work correctly? We still don't know.

It is described right under the sentence you quoted. But let me explain it for you:

An average desktop monitor is 21" and 1920x1080 pixels which is about 105PPI (pixel per inch).
An average mobile screen is around 6.1" and 1080×2340 pixels which is about 420PPI.
Now you use your mobile (on your screenshot as well) in portrait orientation (but even if not, the rest of the UI takes up at least 33% of the available screen area) therefor you need to view the monitor's 1920 pixels scaled down to the mobile's 1080 pixels. That's already a 56% of reduction of pixels amount.
Then you need to factor in the above mentioned PPI difference which results an additional 75% size reduction.
Now if you use normal icon sizes on your desktop, you use 64x64 pixels icons which results a relatively usable icon size of 16x16mm (plus text and extra area size for the highlight effect) with a default text height of 10 pixels which is 2,4mm. For reference an average mobile has about 12x12mm icons on the screen with less than 2mm of text height.
Now if you factor in the above described screen downscaling which happens when you connect to a desktop from your mobile, you will have a downscale factor that makes the desktop icons on your mobile screen 2x2mm in size with a text height of 0,3mm.

Do I need to elaborate further..?

Also I still not really understand the logic of breaking major functionality for a sake of a new skin.
If you referring the point of "remote control is not usable on the mobile version of modern UI" then no, I only posted it on the discord channel several months back. But tbh I would still expect that a development cycle of this software contains actual functional testing of the major functions of the software before a major change like a new UI is getting pushed out.

We can always set the default to the classic UI and have people that want the new skin to opt-in. But we have to make the switch one day, and the more reports/users we have, the faster we can debug.

I do understand that you are pushing for a switch, I for myself really looking for the new UI as well. Especially looking forward to use Melo's Stylish UI. Yet I think this would be a major functionality loss and would like to suggest to at least fix the missing "Full Screen button" functionality (and the additional buttons and functions that comes when you switch to "Full Screen") for modern UI's mobile view before you introduce this change.

[marclaporte]

Thank you @DaanSelen for the initiative here and thank you @aelfwine88 and @panreyes for the feedback.

FYI: the initial PR for Bootstrap was started in 2024-07:
#6450

I am glad we are now debatting when/how to make it the default. My team is ready, willing, and able to give one more push to make us all globally comfortable to make the switch.

@Ndaboom @kambereBr Please urgently address the missing Full Screen button described above.

@aelfwine88 and all: For any other concerns, please create distinct issues and assign them to @Ndaboom @kambereBr and they will coordinate together to handle. And once it becomes the default, we should all expect a bump in issues. Please just ping @Ndaboom and @kambereBr on them as well, so we make sure to address them promptly.

[aelfwine88]

@marclaporte thanks for the professional feedback. I'm happy to test if there will be any new release and create a ticket if I find something problematic.

[DaanSelen]

Thank you @DaanSelen for the initiative here and thank you @aelfwine88 and @panreyes for the feedback.

Thank you for the time, lets get the modern UI as default. That in the least is my objective!

[kambereBr]

Thank you @DaanSelen for the initiative here and thank you @aelfwine88 and @panreyes for the feedback.

FYI: the initial PR for Bootstrap was started in 2024-07: #6450

I am glad we are now debatting when/how to make it the default. My team is ready, willing, and able to give one more push to make us all globally comfortable to make the switch.

@Ndaboom @kambereBr Please urgently address the missing Full Screen button described above.

@aelfwine88 and all: For any other concerns, please create distinct issues and assign them to @Ndaboom @kambereBr and they will coordinate together to handle. And once it becomes the default, we should all expect a bump in issues. Please just ping @Ndaboom and @kambereBr on them as well, so we make sure to address them promptly.

Related PR: #7793

[adamdewolf]

I made a temp fix on our server for the broken Bootstrap remote desktop interface that basically loads the classic interface only for the agent selection and remote stuff when it detects a mobile client.

Style 3 everywhere else, overridden to style 1 on mobile for remote.

Still a few bugs, but I'll post the code somewhere soon.